gopls/internal/lsp/analysis/unusedparams: document the blank identifier

Improve documentation around the blank identifier in the unusedparams analyzer. Referring to "underscored" names is confusing, as that may reasonably be interpreted as referring to names like "_foo". Fixes golang/go#60682 Change-Id: I90e4bc47fad230c5843e69395c055ebe77ad498a Reviewed-on: https://go-review.googlesource.com/c/tools/+/524835 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Robert Findley <[email protected]> Reviewed-by: Alan Donovan <[email protected]>
golang · Aug 31, 2023 · 914b218 · 914b218
1 parent 8234134
commit 914b218
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/gopls/doc/analyzers.md b/gopls/doc/analyzers.md
@@ -632,7 +632,7 @@ any parameters that are not being used.
 
 To reduce false positives it ignores:
 - methods
-- parameters that do not have a name or are underscored
+- parameters that do not have a name or have the name '_' (the blank identifier)
 - functions in test files
 - functions with empty bodies or those with just a return stmt
 

diff --git a/gopls/internal/lsp/analysis/unusedparams/unusedparams.go b/gopls/internal/lsp/analysis/unusedparams/unusedparams.go
@@ -24,7 +24,7 @@ any parameters that are not being used.
 
 To reduce false positives it ignores:
 - methods
-- parameters that do not have a name or are underscored
+- parameters that do not have a name or have the name '_' (the blank identifier)
 - functions in test files
 - functions with empty bodies or those with just a return stmt`
 

diff --git a/gopls/internal/lsp/source/api_json.go b/gopls/internal/lsp/source/api_json.go