x/tools/cmd/heapview/internal/core: stub mmapfile for !darwin,!linux

mmapfile.go uses symbols in the syscall package that are not defined on windows and some other operating systems. Temporarily buildtag-restrict mmapfile to darwin and linux (the platforms easiest for me to test) to fix the build. Change-Id: Ib056608a655b6d32170cd86deac785811e7bc0d1 Reviewed-on: https://go-review.googlesource.com/26830 Reviewed-by: Brad Fitzpatrick <[email protected]>
golang · Aug 11, 2016 · 68cf185 · 68cf185
1 parent 62f0028
commit 68cf185
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/cmd/heapview/internal/core/mmapfile.go b/cmd/heapview/internal/core/mmapfile.go
@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
+// +build darwin linux
+
 package core
 
 import (

diff --git a/cmd/heapview/internal/core/mmapfile_other.go b/cmd/heapview/internal/core/mmapfile_other.go
@@ -0,0 +1,14 @@
+// Copyright 2016 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// +build !darwin,!linux
+
+package core
+
+// TODO(matloob): perhaps use the more portable golang.org/x/exp/mmap
+// instead of the mmap code in mmapfile.go.
+
+type mmapFile struct{}
+
+func (m *mmapFile) Close() error { return nil }