Skip to content

Commit

Permalink
gopls/internal/regtest: unskip Test_Issue38211
Browse files Browse the repository at this point in the history
This test was originally skipped due to deadline exceeded errors. In the
time since, we've made performance improvements, fixed races, and
altered the regtests to remove arbitrary deadlines. Unskip it to see if
it still flakes.

For golang/go#44098
For golang/go#53878

Change-Id: I06530f2bc9c6883f415dc9147cfcbf260abb2a00
Reviewed-on: https://go-review.googlesource.com/c/tools/+/418898
Run-TryBot: Robert Findley <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
  • Loading branch information
findleyr committed Jul 25, 2022
1 parent 1cfe623 commit 178fdf9
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions gopls/internal/regtest/diagnostics/diagnostics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -636,8 +636,6 @@ var ErrHelpWanted error

// Test for golang/go#38211.
func Test_Issue38211(t *testing.T) {
t.Skipf("Skipping flaky test: https://golang.org/issue/44098")

testenv.NeedsGo1Point(t, 14)
const ardanLabs = `
-- go.mod --
Expand Down

0 comments on commit 178fdf9

Please sign in to comment.