Skip to content

Commit

Permalink
config: temporarily allow 'devel' go version
Browse files Browse the repository at this point in the history
Many Go team members testing telemetry use gopls built with the go
built from tip.

Attempted to add 'devel' to config in cl/534476 but it turned out
we also need to update configgen.

Updates golang/go#62271

Change-Id: I3217ce491eb676436ef61a9be9413d87c2815467
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/534855
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Auto-Submit: Hyang-Ah Hana Kim <[email protected]>
  • Loading branch information
hyangah authored and gopherbot committed Oct 12, 2023
1 parent 29ff18e commit 8995ee8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions internal/configgen/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,8 @@ func goVersions() ([]string, error) {
vers = append(vers, v)
}
sort.Sort(byGoVersion(vers))
// TODO(golang/go#62271): temporarily monitor 'devel'.
vers = append(vers, "devel")
return vers, nil
}

Expand Down
2 changes: 1 addition & 1 deletion internal/configgen/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ version: v0.14.0
want := telemetry.UploadConfig{
GOOS: goos(),
GOARCH: goarch(),
GoVersion: []string{"go1.20", "go1.21.0"},
GoVersion: []string{"go1.20", "go1.21.0", "devel"},
Programs: []*telemetry.ProgramConfig{{
Name: "golang.org/x/tools/gopls",
Versions: []string{
Expand Down

0 comments on commit 8995ee8

Please sign in to comment.