-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: add console ConPTY API #175
Conversation
Add Windows ConPTY API, specifically CreatePseudoConsole, ClosePseudoConsole, and ResizePseudoConsole. See: https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/ See: https://learn.microsoft.com/en-us/windows/console/creating-a-pseudoconsole-session Signed-off-by: Ayman Bagabas <[email protected]>
This PR (HEAD: 2537b32) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/528915. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Ayman Bagabas: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Quim Muntal: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
This PR (HEAD: 21cda7e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/528915. Important tips:
|
Message from Ayman Bagabas: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Quim Muntal: Patch Set 4: Code-Review+2 Commit-Queue+1 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-09-26T16:00:55Z","revision":"be59768ef900a4ffb83f7d6a564489316803d9b8"} Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Quim Muntal: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Bryan Mills: Patch Set 4: Code-Review+1 Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Message from Bryan Mills: Patch Set 4: -Hold (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528915. |
Add Windows ConPTY API, specifically CreatePseudoConsole, ClosePseudoConsole, and ResizePseudoConsole. See https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/ See https://learn.microsoft.com/en-us/windows/console/creating-a-pseudoconsole-session Updates #62708 Change-Id: I433c4d9d8716dd75fa44291ab0cf6ef3c5f6a913 GitHub-Last-Rev: 21cda7e GitHub-Pull-Request: #175 Reviewed-on: https://go-review.googlesource.com/c/sys/+/528915 Run-TryBot: Quim Muntal <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Quim Muntal <[email protected]> Reviewed-by: Than McIntosh <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/528915 has been merged. |
Add Windows ConPTY API, specifically CreatePseudoConsole, ClosePseudoConsole, and ResizePseudoConsole.
See https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/
See https://learn.microsoft.com/en-us/windows/console/creating-a-pseudoconsole-session
Updates #62708