-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unix: fix last argument of pselect6 on linux #167
Conversation
On Linux, the last argument of pselect6 system call is **not** a sigseg_t * pointer, but instead it is a structure of the form: struct { const sigset_t *ss; /* Pointer to signal set */ size_t ss_len; /* Size (in bytes) of object pointed }; See man 2 pselect6. Fixes #61251
This PR (HEAD: 3c1041b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/510195. Important tips:
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
Message from Jesse Rittner: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
This PR (HEAD: b77b37a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/510195. Important tips:
|
Message from Bryan Mills: Patch Set 2: Code-Review+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
Message from Mauri de Souza Meneguzzo: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
Message from Mauri de Souza Meneguzzo: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
This PR (HEAD: 29a4f6b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/510195. Important tips:
|
Message from Ian Lance Taylor: Patch Set 3: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
Message from Bryan Mills: Patch Set 3: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
Message from Mauri de Souza Meneguzzo: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
This PR (HEAD: 364d4d2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/510195. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
This PR (HEAD: cb3c6d7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/510195. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
Message from Mauri de Souza Meneguzzo: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
Message from Ian Lance Taylor: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
Message from Ian Lance Taylor: Patch Set 7: Auto-Submit+1 Code-Review+2 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510195. |
On Linux, the last argument of pselect6 system call is **not** a sigseg_t * pointer, but instead it is a structure of the form: struct { const sigset_t *ss; /* Pointer to signal set */ size_t ss_len; /* Size (in bytes) of object pointed }; See man 2 pselect6. Fixes #61251 Change-Id: Id0aa122a77796713bc6d624dc395d396fbc0c5e2 GitHub-Last-Rev: cb3c6d7 GitHub-Pull-Request: #167 Reviewed-on: https://go-review.googlesource.com/c/sys/+/510195 Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]>
This PR is being closed because golang.org/cl/510195 has been merged. |
On Linux, the last argument of pselect6 system call is not a
sigseg_t * pointer, but instead it is a structure of the form:
See man 2 pselect6.
Fixes #61251