Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2: parse RFC 6749 error response #610

Closed
wants to merge 1 commit into from
Closed

oauth2: parse RFC 6749 error response #610

wants to merge 1 commit into from

Conversation

hickford
Copy link
Contributor

@hickford hickford commented Nov 16, 2022 •
edited
Loading

Parse error response described in https://datatracker.ietf.org/doc/html/rfc6749#section-5.2

Handle unorthodox servers responding 200 in error case.

Implements API changes in accepted proposal golang/go#58125

Fixes #441
Fixes #274
Updates #173

@gopherbot
Copy link
Contributor

This PR (HEAD: a2263fc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/451076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 8679a32) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/451076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: cefb6d2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/451076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: cffa1bd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/451076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@hickford hickford marked this pull request as ready for review November 17, 2022 05:18
@gopherbot
Copy link
Contributor

This PR (HEAD: 40ae513) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/451076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 800ea71) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/451076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@hickford hickford mentioned this pull request Nov 30, 2022
Closed
@hickford hickford changed the title Add error fields to RetrieveError Add rfc6749 error fields to RetrieveError Dec 30, 2022
@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 11: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 11: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@hickford hickford mentioned this pull request Jan 28, 2023
Closed
@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: cbc7e73) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/451076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@hickford hickford changed the title Add rfc6749 error fields to RetrieveError oauth2: add rfc6749 error fields to RetrieveError Apr 6, 2023
@gopherbot
Copy link
Contributor

This PR (HEAD: 7d8a7b1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/451076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 15: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 15: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@hickford hickford changed the title oauth2: add rfc6749 error fields to RetrieveError oauth2: parse RFC 6749 error response Apr 6, 2023
@gopherbot
Copy link
Contributor

This PR (HEAD: 0030e27) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/451076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 17: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 17: Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 17: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 17: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 17: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/451076.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 11, 2023
@hickford @neild
oauth2: parse RFC 6749 error response
cfe200d 
Parse error response described in https://datatracker.ietf.org/doc/html/rfc6749#section-5.2

Handle unorthodox servers responding 200 in error case.

Implements API changes in accepted proposal golang/go#58125

Fixes #441
Fixes #274
Updates #173

Change-Id: If9399c3f952ac0501edbeefeb3a71ed057ca8d37
GitHub-Last-Rev: 0030e27
GitHub-Pull-Request: #610
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/451076
Run-TryBot: Matt Hickford <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
Reviewed-by: Matt Hickford <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Cody Oss <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/451076 has been merged.

@gopherbot gopherbot closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hickford @gopherbot