-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: send an error of FLOW_CONTROL_ERROR when exceed the maximum octets #204
Conversation
This PR (HEAD: df9d077) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/561035. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
Message from Damien Neil: Patch Set 3: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-05T23:28:48Z","revision":"f55772936b1ee1ae4fe2ef07bff3a9a0ec8f6805"} Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
Message from Damien Neil: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
… the maximum octets According to rfc9113, if a sender receives a WINDOW_UPDATE that causes a flow-control window to exceed this maximum, it MUST terminate either the stream or the connection, as appropriate. For streams, the sender sends a RST_STREAM with an error code of FLOW_CONTROL_ERROR. Signed-off-by: bestgopher <[email protected]>
This PR (HEAD: d1a85d3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/561035. Important tips:
|
Message from 刘洋: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
Message from Damien Neil: Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-27T23:00:27Z","revision":"248af006dcec862bb44eda867bfc4fae9b49edce"} Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
Message from Damien Neil: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/561035. |
…tets According to rfc9113 "https://www.rfc-editor.org/rfc/rfc9113.html#section-6.9.1-7", if a sender receives a WINDOW_UPDATE that causes a flow-control window to exceed this maximum, it MUST terminate either the stream or the connection, as appropriate. For streams, the sender sends a RST_STREAM with an error code of FLOW_CONTROL_ERROR. Change-Id: I5e14db247012ebc860a23053f73e70b83c7cd85d GitHub-Last-Rev: d1a85d3 GitHub-Pull-Request: #204 Reviewed-on: https://go-review.googlesource.com/c/net/+/561035 Auto-Submit: Damien Neil <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Damien Neil <[email protected]>
This PR is being closed because golang.org/cl/561035 has been merged. |
According to rfc9113 "https://www.rfc-editor.org/rfc/rfc9113.html#section-6.9.1-7", if a sender receives a WINDOW_UPDATE that causes a flow-control window to exceed this maximum, it MUST terminate either the stream or the connection, as appropriate. For streams, the sender sends a RST_STREAM with an error code of FLOW_CONTROL_ERROR.