This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 607
Commits on May 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1b70444 - Browse repository at this point
Copy the full SHA 1b70444View commit details
Commits on May 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 451e3ae - Browse repository at this point
Copy the full SHA 451e3aeView commit details
Commits on May 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 88eac44 - Browse repository at this point
Copy the full SHA 88eac44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1499fae - Browse repository at this point
Copy the full SHA 1499faeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e95b356 - Browse repository at this point
Copy the full SHA e95b356View commit details
Commits on May 13, 2018
-
I thought that VS Code did this for me but for some reason it seemed to miss this one thing
Configuration menu - View commit details
-
Copy full SHA for be4106f - Browse repository at this point
Copy the full SHA be4106fView commit details
Commits on Jun 2, 2018
-
One will explicitly assert what I meant for it too and there is a new one to catch the fact that there are more possible matching errors that exist which must be handled accordingly
Configuration menu - View commit details
-
Copy full SHA for 1179e2b - Browse repository at this point
Copy the full SHA 1179e2bView commit details -
In the previous commit I have a test which is broken partially because it is and partially because it is the wrong test. This is fixed in this commit. As well as another test which discovered during development.
Configuration menu - View commit details
-
Copy full SHA for eb129e4 - Browse repository at this point
Copy the full SHA eb129e4View commit details -
After adding some failing test cases I made the necessary changes to get it working now some refactor
Configuration menu - View commit details
-
Copy full SHA for d4b1073 - Browse repository at this point
Copy the full SHA d4b1073View commit details -
Slight refactor to remove the need to pass booleans arround
I have always undetstood passing booleans into functions to be a codesmell so instead of calling `FindMatch` with the isLoose flag I have opted to call two different functions bassed on weather the isLoose flag is set. This chould be taken one step further and be made part of the `CallSet` itself but was not sure if that abstraction made sense
Configuration menu - View commit details
-
Copy full SHA for fb03c77 - Browse repository at this point
Copy the full SHA fb03c77View commit details -
Add test for ordering in LooseMode
After some further dive down I have realized that After does not work in LooseMode assuming we want to maintain a close to exact feature set I have added a test to demonstrate this failing behavior. Fix to come.
Configuration menu - View commit details
-
Copy full SHA for a4f6f46 - Browse repository at this point
Copy the full SHA a4f6f46View commit details -
Add method to check Call preReqs and take the check out of match
weather a calls prereqs are met doesn't seem semntically signifigant to weather it is a match so I removed that as a dependancy and now call it in the `callSet`s `FindMatch` methods which allows each version to decide if that is necessary. This change enables us to fix the fact that `After` does not work with LooseMode
Configuration menu - View commit details
-
Copy full SHA for cab11cc - Browse repository at this point
Copy the full SHA cab11ccView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.