Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Add loose mocks #188

Closed
wants to merge 12 commits into from
Closed

Add loose mocks #188

wants to merge 12 commits into from

Commits on May 8, 2018

  1. Configuration menu
    Copy the full SHA
    1b70444 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2018

  1. Configuration menu
    Copy the full SHA
    451e3ae View commit details
    Browse the repository at this point in the history

Commits on May 12, 2018

  1. Configuration menu
    Copy the full SHA
    88eac44 View commit details
    Browse the repository at this point in the history
  2. Clean up some test code

    jjm3x3 committed May 12, 2018
    Configuration menu
    Copy the full SHA
    1499fae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e95b356 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2018

  1. Fix the go formatting

    I thought that VS Code did this for me but for some reason it seemed to
    miss this one thing
    jjm3x3 committed May 13, 2018
    Configuration menu
    Copy the full SHA
    be4106f View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2018

  1. Add a few tests

    One will explicitly assert what I meant for it too and there is a new
    one to catch the fact that there are more possible matching errors that
    exist which must be handled accordingly
    jjm3x3 committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    1179e2b View commit details
    Browse the repository at this point in the history
  2. Tweak the tests

    In the previous commit I have a test which is broken partially because
    it is and partially because it is the wrong test. This is fixed in this
    commit. As well as another test which discovered during development.
    jjm3x3 committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    eb129e4 View commit details
    Browse the repository at this point in the history
  3. Get it working

    After adding some failing test cases I made the necessary changes to get
    it working now some refactor
    jjm3x3 committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    d4b1073 View commit details
    Browse the repository at this point in the history
  4. Slight refactor to remove the need to pass booleans arround

    I have always undetstood passing booleans into functions to be a
    codesmell so instead of calling `FindMatch` with the isLoose flag I have
    opted to call two different functions bassed on weather the isLoose flag
    is set. This chould be taken one step further and be made part of the
    `CallSet` itself but was not sure if that abstraction made sense
    jjm3x3 committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    fb03c77 View commit details
    Browse the repository at this point in the history
  5. Add test for ordering in LooseMode

    After some further dive down I have realized that After does not work in
    LooseMode assuming we want to maintain a close to exact feature set I
    have added a test to demonstrate this failing behavior. Fix to come.
    jjm3x3 committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    a4f6f46 View commit details
    Browse the repository at this point in the history
  6. Add method to check Call preReqs and take the check out of match

    weather a calls prereqs are met doesn't seem semntically signifigant to
    weather it is a match so I removed that as a dependancy and now call it
    in the `callSet`s `FindMatch` methods which allows each version to
    decide if that is necessary. This change enables us to fix the fact
    that `After` does not work with LooseMode
    jjm3x3 committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    cab11cc View commit details
    Browse the repository at this point in the history