Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

Commit

Permalink
all: re-introduce go.mod and go.sum files
Browse files Browse the repository at this point in the history 
Now that tools' dependencies have been cleaned up in golang.org/cl/160837, lint
doesn't have any transitive dependencies on modules that import it using the
wrong path. It is now safe to reintroduce a go.mod file to this repo. I've
checked using dmitshur's instructions in
#436 (comment) that lint only
appears with its canonical module path in the build list.

Updates #436

Change-Id: I6343aa103408b20562e17ea019602b159b899fc6
Reviewed-on: https://go-review.googlesource.com/c/lint/+/166278
Run-TryBot: Michael Matloob <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
  • Loading branch information
@matloob
matloob committed Mar 13, 2019
1 parent 5614ed5 commit d0100b6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
3 changes: 3 additions & 0 deletions go.mod
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module golang.org/x/lint

require golang.org/x/tools v0.0.0-20190311212946-11955173bddd
6 changes: 6 additions & 0 deletions go.sum
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/tools v0.0.0-20190311212946-11955173bddd h1:/e+gpKk9r3dJobndpTytxS2gOy6m5uvpg+ISQoEcusQ=
golang.org/x/tools v0.0.0-20190311212946-11955173bddd/go.mod h1:LCzVGOaR6xXOjkQ3onu1FJEFr0SW1gC7cKk1uF8kGRs=

2 comments on commit d0100b6

@giautm
Copy link

@giautm giautm commented on d0100b6 Mar 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matloob : I get this error when upgrade another module. Is go.mod valid?

go: github.com/golang/[email protected]: parsing go.mod: unexpected module path "golang.org/x/lint"`

go version go1.11.2 darwin/amd64

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented on d0100b6 Mar 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giautm That general issue is being tracked in golang/go#30831.

I'll lock conversation on this commit, because we don't generally use that feature of GitHub. You can file or comment on an issue instead. Thanks.

Please sign in to comment.