runtime: crash asap and extend total sleep time for slow machine in test #65018

zzkcode · 2024-01-08T14:56:34Z

Running with few threads usually does not need 500ms to crash, so let it
crash as soon as possible. While the test may caused more time on slow
machine, try to expand the sleep time in test.

Updates #64752

gopherbot · 2024-01-08T15:03:31Z

This PR (HEAD: 2eb8fef) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/554615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-08T15:10:32Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T16:14:58Z

Message from Michael Pratt:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T16:44:12Z

This PR (HEAD: 02acc7b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/554615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-08T16:51:26Z

Message from zk Z:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T16:51:33Z

This PR (HEAD: 547660e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/554615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-08T16:58:50Z

Message from zk Z:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T16:58:51Z

Message from Michael Pratt:

Patch Set 3: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T16:58:52Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-01-08T16:45:24Z","revision":"6cbd78dd9cc41ffc06edcba148769609e2350043"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T16:58:53Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T16:58:54Z

Message from zk Z:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T17:20:02Z

Message from Michael Pratt:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T17:20:03Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-01-08T17:09:02Z","revision":"19310e5429428c127bdf72e4ed32fc1a6b94df9a"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T17:40:31Z

Message from Michael Pratt:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T17:40:32Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T17:40:33Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T18:01:17Z

Message from Michael Pratt:

Patch Set 4: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T19:46:12Z

Message from Bryan Mills:

Patch Set 5: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T21:31:02Z

Message from Michael Pratt:

Patch Set 5: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T13:50:22Z

Message from zk Z:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T17:15:02Z

Message from Bryan Mills:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-10T13:01:27Z

Message from zk Z:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-10T13:49:09Z

This PR (HEAD: 51ec6df) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/554615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-10T17:07:15Z

Message from Bryan Mills:

Patch Set 6: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-10T17:21:30Z

Message from Bryan Mills:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-11T16:03:59Z

Message from zk Z:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-11T16:25:42Z

Message from Bryan Mills:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-12T15:30:51Z

Message from zk Z:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

ankit-gautam23 · 2024-01-25T13:22:34Z

src/runtime/signal_unix.go

+			// Sleep for short intervals so that we can crash quickly after all ms have received SIGQUIT.
+			// Reset the timer whenever we see more ms received SIGQUIT
+			// to make it have enough time to crash (see issue #64752).
+			timeout := watchdogTimeoutMicros


So many variable assignments I can see, just suggesting a small piece of code below

for timeout := watchdogTimeoutMicros; timeout > 0 && crashing.Load() < mcount()-int32(extraMLength.Load()); timeout -= crashSleepMicros { usleep(crashSleepMicros) if crashing.Load() > maxCrashing { maxCrashing = crashing.Load() timeout = watchdogTimeoutMicros } }

Thanks, this pr has pending for Go 1.22 release before since the test failure may caused by another issue. So this may not able to fix the issue, see gerrit for more details.

gopherbot · 2024-02-01T18:06:30Z

Message from Felix Geisendörfer:

Patch Set 6: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-01T18:38:25Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-01T17:57:07Z","revision":"d80e0b5bafbeb5266ac1c78a8123230e393cb3ae"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-01T18:57:09Z

Message from Felix Geisendörfer:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-01T18:57:10Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-01T18:57:11Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-08T19:32:18Z

Message from Cherry Mui:

Patch Set 6: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-08T19:32:18Z

Message from Cherry Mui:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T01:15:27Z

Message from zk Z:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T02:33:08Z

Message from Cherry Mui:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T02:58:22Z

Message from zk Z:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T03:04:12Z

Message from Cherry Mui:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T04:09:10Z

Message from Archana Ravindar:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

Fixes golang#64752

gopherbot · 2024-05-10T14:51:07Z

This PR (HEAD: 84f3844) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/554615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-10T15:49:30Z

Message from zk Z:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T15:55:47Z

Message from Cherry Mui:

Patch Set 7: Auto-Submit+1 Code-Review+1 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T16:02:11Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-10T15:48:04Z","revision":"d5a0b437d4e0fecf6bde6646b360ee7abd8f83f7"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/554615.
After addressing review feedback, remember to publish your drafts!

Running with few threads usually does not need 500ms to crash, so let it crash as soon as possible. While the test may caused more time on slow machine, try to expand the sleep time in test. Updates #64752 Change-Id: I635fab846bd5e1735808d4d47bb9032d5a04cc2b GitHub-Last-Rev: 84f3844 GitHub-Pull-Request: #65018 Reviewed-on: https://go-review.googlesource.com/c/go/+/554615 Reviewed-by: Michael Pratt <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Auto-Submit: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]>

gopherbot · 2024-05-10T16:08:44Z

This PR is being closed because golang.org/cl/554615 has been merged.

zzkcode force-pushed the runtime_fix-crash-time branch from 547660e to 51ec6df Compare January 10, 2024 13:48

ankit-gautam23 reviewed Jan 25, 2024

View reviewed changes

zzkcode added 4 commits May 10, 2024 22:42

runtime: crash asap and extend total sleep time for slow machine in test

83d9ae6

Fixes golang#64752

runtime: set sleep to 60s in coreCrashThreadSource

719c92c

runtime: remove extra line

e21d0ef

runtime: crash asap and extend sleep time

84f3844

zzkcode force-pushed the runtime_fix-crash-time branch from 51ec6df to 84f3844 Compare May 10, 2024 14:48

gopherbot closed this May 10, 2024

runtime: crash asap and extend total sleep time for slow machine in test #65018

runtime: crash asap and extend total sleep time for slow machine in test #65018

Conversation

zzkcode commented Jan 8, 2024 • edited Loading

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 10, 2024

gopherbot commented Jan 10, 2024

gopherbot commented Jan 10, 2024

gopherbot commented Jan 10, 2024

gopherbot commented Jan 11, 2024

gopherbot commented Jan 11, 2024

gopherbot commented Jan 12, 2024

ankit-gautam23 Jan 25, 2024

Choose a reason for hiding this comment

zzkcode Feb 8, 2024

Choose a reason for hiding this comment

gopherbot commented Feb 1, 2024

gopherbot commented Feb 1, 2024

gopherbot commented Feb 1, 2024

gopherbot commented Feb 1, 2024

gopherbot commented Feb 1, 2024

gopherbot commented May 8, 2024

gopherbot commented May 8, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

zzkcode commented Jan 8, 2024 •

edited

Loading