net/http: make Request.Clone create fresh copies for matches and otherValues #64913

callthingsoff · 2024-01-01T01:03:14Z

This change fixes Request.Clone to correctly work with SetPathValue
by creating fresh copies for matches and otherValues so that
SetPathValue for cloned requests doesn't pollute the original request.

While here, also added a doc for Request.SetPathValue.

Fixes #64911

gopherbot · 2024-01-01T01:07:52Z

This PR (HEAD: 1ca0941) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553375.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-01T01:14:05Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T01:20:23Z

This PR (HEAD: fbb3f76) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553375.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-01T01:49:55Z

This PR (HEAD: a673160) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553375.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-01T02:02:46Z

Message from Jes Cok:

Patch Set 3: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T02:02:47Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T02:02:47Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T02:15:28Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T02:15:29Z

Message from Jes Cok:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T02:38:08Z

Message from Jes Cok:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T04:26:27Z

Message from Emmanuel Odeke:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T04:39:05Z

This PR (HEAD: d177cf8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553375.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-01T04:45:18Z

Message from Jes Cok:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T04:45:18Z

Message from Jes Cok:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T04:51:28Z

Message from Emmanuel Odeke:

Patch Set 4: Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T04:51:29Z

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T04:57:35Z

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T04:57:36Z

Message from Jes Cok:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T05:03:46Z

Message from Gopher Robot:

Patch Set 4: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T15:29:33Z

Message from Ingo Oeser:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T15:42:10Z

Message from Jes Cok:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T01:26:48Z

Message from Jonathan Amsterdam:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T01:33:15Z

Message from Emmanuel Odeke:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T04:22:59Z

Message from Jes Cok:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T11:55:38Z

Message from Jes Cok:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T14:08:42Z

Message from Jonathan Amsterdam:

Patch Set 4: Code-Review+2

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T14:08:42Z

Message from Jonathan Amsterdam:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T14:15:19Z

Message from Jonathan Amsterdam:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T14:21:57Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-01-02T14:05:09Z","revision":"a8b19e4b0f266e0f72728dab3f7cf83f32d264ec"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T14:21:58Z

Message from Jonathan Amsterdam:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T14:21:59Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

FAILURE

go on master (change 553375)

Tests failed. See all test results.

Error:
shard 4: failed to run "go tool dist test -json": exit status 1

Links:

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T14:22:00Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T23:25:41Z

Message from Jes Cok:

Patch Set 4: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-03T04:18:10Z

Message from Jes Cok:

Patch Set 4: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-03T04:18:11Z

Message from Jes Cok:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-03T04:18:20Z

This PR (HEAD: 1981db1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553375.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-03T04:31:12Z

Message from Jes Cok:

Patch Set 5: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-03T04:37:38Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-03T04:44:00Z

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-03T09:01:49Z

Message from Ingo Oeser:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-03T14:44:17Z

Message from Jes Cok:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-03T16:56:43Z

Message from Jes Cok:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553375.
After addressing review feedback, remember to publish your drafts!

…rValues This change fixes Request.Clone to correctly work with SetPathValue by creating fresh copies for matches and otherValues so that SetPathValue for cloned requests doesn't pollute the original request. While here, also added a doc for Request.SetPathValue. Fixes #64911 Change-Id: I2831b38e135935dfaea2b939bb9db554c75b65ef GitHub-Last-Rev: 1981db1 GitHub-Pull-Request: #64913 Reviewed-on: https://go-review.googlesource.com/c/go/+/553375 Reviewed-by: Emmanuel Odeke <[email protected]> Run-TryBot: Jes Cok <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>

gopherbot · 2024-01-03T17:50:05Z

This PR is being closed because golang.org/cl/553375 has been merged.

…rValues This change fixes Request.Clone to correctly work with SetPathValue by creating fresh copies for matches and otherValues so that SetPathValue for cloned requests doesn't pollute the original request. While here, also added a doc for Request.SetPathValue. Fixes golang#64911 Change-Id: I2831b38e135935dfaea2b939bb9db554c75b65ef GitHub-Last-Rev: 1981db1 GitHub-Pull-Request: golang#64913 Reviewed-on: https://go-review.googlesource.com/c/go/+/553375 Reviewed-by: Emmanuel Odeke <[email protected]> Run-TryBot: Jes Cok <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>

net/http: fix Request.Clone with SetPathValue

1ca0941

Fixes #64911

re

fbb3f76

re

a673160

re

d177cf8

callthingsoff changed the title ~~net/http: fix Request.Clone with SetPathValue~~ net/http: make Request.Clone create fresh copies for matches and otherValues Jan 1, 2024

remove #

1981db1

gopherbot closed this Jan 3, 2024

callthingsoff deleted the http_copies branch January 3, 2024 17:52

net/http: make Request.Clone create fresh copies for matches and otherValues #64913

net/http: make Request.Clone create fresh copies for matches and otherValues #64913

Conversation

callthingsoff commented Jan 1, 2024 • edited Loading

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 1, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

gopherbot commented Jan 3, 2024

gopherbot commented Jan 3, 2024

gopherbot commented Jan 3, 2024

gopherbot commented Jan 3, 2024

gopherbot commented Jan 3, 2024

gopherbot commented Jan 3, 2024

gopherbot commented Jan 3, 2024

gopherbot commented Jan 3, 2024

gopherbot commented Jan 3, 2024

gopherbot commented Jan 3, 2024

callthingsoff commented Jan 1, 2024 •

edited

Loading