cmd/fix: support go versions with patch release #62586

alexbozhenko · 2023-09-12T06:52:20Z

Support go version with patch release(e.g. 1.21.0)
and release candidates(e.g. 1.21rc1)
when parsing the go version in the fix command
by using new "go/version" package.

Fixes #62584

gopherbot · 2023-09-12T06:59:34Z

This PR (HEAD: 9de6053) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527342.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-12T07:06:00Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-12T07:06:01Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-12T07:25:23Z

Message from Alex Bozhenko:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-12T14:36:19Z

Message from Alex Bozhenko:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-27T04:12:18Z

Message from Alex Bozhenko:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-28T18:38:26Z

Message from Russ Cox:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-01T07:38:35Z

This PR (HEAD: 6147ade) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527342.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-01T07:58:07Z

Message from Alex Bozhenko:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T17:52:07Z

Message from Russ Cox:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T17:52:07Z

Message from Russ Cox:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T17:52:08Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T17:52:08Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T18:04:47Z

Message from Gopher Robot:

Patch Set 2: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T21:40:12Z

Message from Bryan Mills:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-03T00:17:48Z

This PR (HEAD: 2bdfc57) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527342.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-03T01:05:08Z

This PR (HEAD: 6440a08) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527342.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-03T03:53:48Z

This PR (HEAD: 83f190e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527342.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-03T06:17:12Z

This PR (HEAD: 4b13fcc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527342.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-03T06:23:04Z

Message from Alex Bozhenko:

Patch Set 6:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-03T15:21:39Z

Message from Alex Bozhenko:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-07T14:46:13Z

Message from Bryan Mills:

Patch Set 7:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-07T15:19:10Z

This PR (HEAD: 76bced5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527342.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-07T15:25:46Z

Message from Alex Bozhenko:

Patch Set 7:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-07T15:32:19Z

Message from Alex Bozhenko:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T22:49:50Z

Message from Bryan Mills:

Patch Set 8: Code-Review+1 Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T22:49:50Z

Message from Bryan Mills:

Patch Set 8: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T22:49:51Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-21T22:39:02Z","revision":"d379632dfd6d8c300cc59b16f193a91705e85eff"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T23:02:37Z

Message from Bryan Mills:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T23:02:37Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T23:02:38Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527342.
After addressing review feedback, remember to publish your drafts!

Support go version with patch release(e.g. 1.21.0) and release candidates(e.g. 1.21rc1) when parsing the go version in the fix command by using new "go/version" package. Fixes #62584 Change-Id: I0ec16137c7a396c68039d374c770c4021fb54b4e GitHub-Last-Rev: 76bced5 GitHub-Pull-Request: #62586 Reviewed-on: https://go-review.googlesource.com/c/go/+/527342 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Russ Cox <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Alex Bozhenko <[email protected]> Reviewed-by: Bryan Mills <[email protected]>

gopherbot · 2024-02-22T05:36:17Z

This PR is being closed because golang.org/cl/527342 has been merged.

Support go version with patch release(e.g. 1.21.0) and release candidates(e.g. 1.21rc1) when parsing the go version in the fix command by using new "go/version" package. For #62584. Fixes #68825. Change-Id: I0ec16137c7a396c68039d374c770c4021fb54b4e GitHub-Last-Rev: 76bced5 GitHub-Pull-Request: #62586 Reviewed-on: https://go-review.googlesource.com/c/go/+/527342 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Russ Cox <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Alex Bozhenko <[email protected]> Reviewed-by: Bryan Mills <[email protected]> (cherry picked from commit 7fd62ba) Reviewed-on: https://go-review.googlesource.com/c/go/+/603981 Reviewed-by: Cherry Mui <[email protected]> TryBot-Bypass: Cherry Mui <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Kirill Kolyshkin <[email protected]>

alexbozhenko force-pushed the fix_cmd_fix_patch_releases branch from 6147ade to 2bdfc57 Compare February 3, 2024 00:13

alexbozhenko force-pushed the fix_cmd_fix_patch_releases branch from 83f190e to 4b13fcc Compare February 3, 2024 06:14

alexbozhenko added 6 commits February 7, 2024 07:17

split by dot

fd24c77

address comments

2abdd34

address comments

e8808ea

fix usage ov version.Lang

b0f236e

use go/version to compare version cli arg

090ef7a

fix build tags

284d433

alexbozhenko added 2 commits February 7, 2024 07:17

fix comparison

b41219c

fix order of imports

76bced5

alexbozhenko force-pushed the fix_cmd_fix_patch_releases branch from 4b13fcc to 76bced5 Compare February 7, 2024 15:17

gopherbot closed this Feb 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/fix: support go versions with patch release #62586

cmd/fix: support go versions with patch release #62586

alexbozhenko commented Sep 12, 2023 •

edited

Loading

gopherbot commented Sep 12, 2023

gopherbot commented Sep 12, 2023

gopherbot commented Sep 12, 2023

gopherbot commented Sep 12, 2023

gopherbot commented Sep 12, 2023

gopherbot commented Sep 27, 2023

gopherbot commented Sep 28, 2023

gopherbot commented Oct 1, 2023

gopherbot commented Oct 1, 2023

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 22, 2024

cmd/fix: support go versions with patch release #62586

cmd/fix: support go versions with patch release #62586

Conversation

alexbozhenko commented Sep 12, 2023 • edited Loading

gopherbot commented Sep 12, 2023

gopherbot commented Sep 12, 2023

gopherbot commented Sep 12, 2023

gopherbot commented Sep 12, 2023

gopherbot commented Sep 12, 2023

gopherbot commented Sep 27, 2023

gopherbot commented Sep 28, 2023

gopherbot commented Oct 1, 2023

gopherbot commented Oct 1, 2023

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 21, 2024

gopherbot commented Feb 22, 2024

alexbozhenko commented Sep 12, 2023 •

edited

Loading