cmd/go: cache results of exec.LookPath #61464

qiulaidongfeng · 2023-07-20T02:28:57Z

This CL package exec.LookPath to internal/cfg.LookPath and adds cache.

BenchmarkLookPath-4 24149096 50.48 ns/op 0 B/op 0 allocs/op

Fixes #36768

gopherbot · 2023-07-20T02:32:16Z

This PR (HEAD: de854e9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511458.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-20T19:00:19Z

Message from Bryan Mills:

Patch Set 2: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T03:23:49Z

Message from qiulaidongfeng:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T04:51:28Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T06:10:36Z

Message from qiulaidongfeng:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T15:11:51Z

Message from Bryan Mills:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-22T02:02:18Z

This PR (HEAD: 9dfac8c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511458.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-22T02:07:51Z

Message from qiulaidongfeng:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-22T02:08:01Z

This PR (HEAD: 2fdab4c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511458.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-25T20:55:07Z

Message from Bryan Mills:

Patch Set 4: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T05:39:28Z

This PR (HEAD: 04cb24b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511458.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-26T05:44:55Z

Message from qiulaidongfeng:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-03T12:55:19Z

Message from qiulaidongfeng:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-05T01:56:26Z

Message from qiulaidongfeng:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-07T11:39:52Z

Message from qiulaidongfeng:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-07T13:20:27Z

Message from Bryan Mills:

Patch Set 5: Hold+1

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

This CL package exec.LookPath to internal/cfg.LookPath and adds cache. BenchmarkLookPath-4 26475454 47.84 ns/op 0 B/op 0 allocs/op Fixes golang#36768 Change-Id: I199a780d1eab9bd5397bb3759bb42191fff716e9 Change-Id: I199a780d1eab9bd5397bb3759bb42191fff716e9 GitHub-Last-Rev: 04cb24b GitHub-Pull-Request: golang#61464

gopherbot · 2023-09-07T14:16:37Z

This PR (HEAD: 1289593) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511458.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-07T14:23:41Z

Message from qiulaidongfeng:

Patch Set 6:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-07T14:30:47Z

Message from Bryan Mills:

Patch Set 6: -Hold

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-07T16:36:05Z

Message from Bryan Mills:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

This CL package exec.LookPath to internal/cfg.LookPath and adds cache. BenchmarkLookPath-4 24149096 50.48 ns/op 0 B/op 0 allocs/op Fixes golang#36768 Change-Id: I199a780d1eab9bd5397bb3759bb42191fff716e9 Change-Id: I199a780d1eab9bd5397bb3759bb42191fff716e9 GitHub-Last-Rev: 04cb24b GitHub-Pull-Request: golang#61464

gopherbot · 2023-09-08T00:37:20Z

This PR (HEAD: 8da56cb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511458.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

This CL package exec.LookPath to internal/cfg.LookPath and adds cache. BenchmarkLookPath-4 24149096 50.48 ns/op 0 B/op 0 allocs/op Fixes golang#36768 Change-Id: I199a780d1eab9bd5397bb3759bb42191fff716e9 Change-Id: I199a780d1eab9bd5397bb3759bb42191fff716e9 GitHub-Last-Rev: 04cb24b GitHub-Pull-Request: golang#61464

gopherbot · 2023-09-08T00:43:30Z

This PR (HEAD: 4e2dd72) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511458.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-08T00:49:24Z

Message from qiulaidongfeng:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T21:23:33Z

Message from Bryan Mills:

Patch Set 8: Code-Review+2 Commit-Queue+1 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T21:23:34Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-08T21:15:21Z","revision":"756840221a5713197a4ece1f246677c86b022e9b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T21:23:35Z

Message from Gopher Robot:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T21:35:06Z

Message from Gopher Robot:

Patch Set 8: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T21:35:07Z

Message from Bryan Mills:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T21:35:08Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T21:35:09Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

This CL package exec.LookPath to internal/cfg.LookPath and adds cache. BenchmarkLookPath-4 24149096 50.48 ns/op 0 B/op 0 allocs/op Fixes golang#36768 Change-Id: I199a780d1eab9bd5397bb3759bb42191fff716e9 Change-Id: I199a780d1eab9bd5397bb3759bb42191fff716e9 GitHub-Last-Rev: 04cb24b GitHub-Pull-Request: golang#61464

gopherbot · 2023-09-09T00:58:28Z

This PR (HEAD: d67aa82) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511458.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-09T01:04:01Z

Message from qiulaidongfeng:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-11T15:47:36Z

Message from Bryan Mills:

Patch Set 9: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-11T15:54:09Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-11T15:38:20Z","revision":"dd2fed4237f31a80611f53656eb7eb5601c4b430"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-11T15:54:10Z

Message from Gopher Robot:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-11T16:00:37Z

Message from Bryan Mills:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-11T16:00:38Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-11T16:00:38Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-11T16:00:39Z

Message from Gopher Robot:

Patch Set 9: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511458.
After addressing review feedback, remember to publish your drafts!

This CL package exec.LookPath to internal/cfg.LookPath and adds cache. BenchmarkLookPath-4 24149096 50.48 ns/op 0 B/op 0 allocs/op Fixes #36768 Change-Id: I199a780d1eab9bd5397bb3759bb42191fff716e9 Change-Id: I199a780d1eab9bd5397bb3759bb42191fff716e9 GitHub-Last-Rev: d67aa82 GitHub-Pull-Request: #61464 Reviewed-on: https://go-review.googlesource.com/c/go/+/511458 Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>

gopherbot · 2023-09-11T20:18:49Z

This PR is being closed because golang.org/cl/511458 has been merged.

qiulaidongfeng force-pushed the 36768 branch from 04cb24b to 1289593 Compare September 7, 2023 14:14

qiulaidongfeng force-pushed the 36768 branch from 1289593 to 8da56cb Compare September 8, 2023 00:34

qiulaidongfeng force-pushed the 36768 branch from 8da56cb to 4e2dd72 Compare September 8, 2023 00:39

qiulaidongfeng force-pushed the 36768 branch from 4e2dd72 to d67aa82 Compare September 9, 2023 00:54

gopherbot closed this Sep 11, 2023

cmd/go: cache results of exec.LookPath #61464

cmd/go: cache results of exec.LookPath #61464

Conversation

qiulaidongfeng commented Jul 20, 2023 • edited by dmitshur Loading

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Jul 25, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Aug 3, 2023

gopherbot commented Aug 5, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 9, 2023

gopherbot commented Sep 9, 2023

gopherbot commented Sep 11, 2023

gopherbot commented Sep 11, 2023

gopherbot commented Sep 11, 2023

gopherbot commented Sep 11, 2023

gopherbot commented Sep 11, 2023

gopherbot commented Sep 11, 2023

gopherbot commented Sep 11, 2023

gopherbot commented Sep 11, 2023

qiulaidongfeng commented Jul 20, 2023 •

edited by dmitshur

Loading