Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httptest: add support for 1XX responses #56151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

net/http/httptest: add support for 1XX responses #56151

wants to merge 2 commits into from

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Oct 11, 2022 •
edited
Loading

The existing implementation doesn't allow tracing
1xx responses.
This patch allows using net/http/httptrace to inspect 1XX responses.

Closes #56346.
Updates #26089.

@gopherbot
Copy link
Contributor

This PR (HEAD: e53ae3b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/442215 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@dunglas dunglas mentioned this pull request Oct 20, 2022
Open
@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/442215.
After addressing review feedback, remember to publish your drafts!

@dunglas
net/http/httptest: add support for 1XX responses
6b9da27 
The existing implementation doesn't allow tracing
1xx responses.
This patch allows using net/http/httptrace to inspect
1XX responses.

Updates golang#26089.
@gopherbot
Copy link
Contributor

This PR (HEAD: 6eb176a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/442215 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Kévin Dunglas:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/442215.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: f6e891e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/442215 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/442215.
After addressing review feedback, remember to publish your drafts!

Acconut added a commit to Acconut/go-httptest-recorder that referenced this pull request Aug 24, 2023
@Acconut
Import changes from golang/go#56151
a9d9347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: net/http/httptest: add support for 1XX responses
2 participants
@dunglas @gopherbot