New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal: use time.DateTime constant #55833

Closed

cuishuang wants to merge 1 commit into golang:master from gopherteam:master

Contributor

cuishuang commented Sep 23, 2022 •

edited

Loading

Use the newly defined time.Datetime constant instead of a string literal.

Updates #52746


          cmd/go/internal: optimize code with newly defined time.DateTime const…

65d3aa9

…ants

Signed-off-by: cui fliter <[email protected]>

Contributor

gopherbot commented Sep 23, 2022

This PR (HEAD: 65d3aa9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/433277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Sep 23, 2022

Message from Joseph Tsai:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433277.
After addressing review feedback, remember to publish your drafts!

cuishuang changed the title ~~cmd/go/internal: optimize code with newly defined time.DateTime const…~~ cmd/go/internal: use time.DateTime constant

Contributor

gopherbot commented Sep 23, 2022

Message from shuang cui:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433277.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 23, 2022

Message from shuang cui:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433277.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 23, 2022

Message from Joseph Tsai:

Patch Set 2: Run-TryBot+1 Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/433277.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 23, 2022

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433277.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 23, 2022

Message from Dmitri Shuralyov:

Patch Set 2: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433277.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 23, 2022

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433277.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          cmd/go/internal: use time.DateTime constant

f6e1677

Use the newly defined time.Datetime constant instead of a string literal.

Updates #52746

Change-Id: I2722415ecc67fd2adfdab2eaba3298774032bff3
GitHub-Last-Rev: 65d3aa9
GitHub-Pull-Request: #55833
Reviewed-on: https://go-review.googlesource.com/c/go/+/433277
Run-TryBot: Joseph Tsai <[email protected]>
Auto-Submit: Joseph Tsai <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Joseph Tsai <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>

Contributor

gopherbot commented Sep 27, 2022

This PR is being closed because golang.org/cl/433277 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet