runtime/trace: add missing events for the locked g in extra M. #54974

doujiang24 · 2022-09-09T13:33:31Z

Extra Ms may lead to the "no consistent ordering of events possible" error when parsing trace file with cgo enabled, since:

The gs in the extra Ms may be in _Gdead status while starting trace by invoking runtime.StartTrace,
and these gs will trigger traceEvGoSysExit events in runtime.exitsyscall when invoking go functions from c,
then, the events of those gs are under non-consistent ordering, due to missing the previous events.

Add two events, traceEvGoCreate and traceEvGoInSyscall, in runtime.StartTrace, will make the trace parser happy.

Fixes #29707

gopherbot · 2022-09-09T13:44:51Z

This PR (HEAD: 1af40a1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/429858 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-09T14:13:41Z

Message from DeJiang Zhu:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-10T07:32:38Z

Message from hopehook:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-10T07:40:56Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-10T08:17:01Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-10T08:48:51Z

Message from hopehook:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-10T11:05:01Z

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-10T16:00:32Z

This PR (HEAD: 2f65d45) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/429858 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-10T16:13:56Z

Message from DeJiang Zhu (doujiang):

Patch Set 1: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-10T16:18:16Z

This PR (HEAD: 4814eee) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/429858 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-12T15:21:06Z

Message from Michael Pratt:

Patch Set 3: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T15:30:39Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T15:30:40Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T18:30:20Z

Message from Gopher Robot:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T18:39:41Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T21:35:08Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-13T01:39:23Z

This PR (HEAD: ebe3b9f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/429858 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-13T01:57:37Z

Message from DeJiang Zhu (doujiang):

Patch Set 4: Code-Review+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-15T06:23:29Z

Message from DeJiang Zhu (doujiang):

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-15T14:46:49Z

Message from Bryan Mills:

Patch Set 4: Code-Review+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-16T03:15:59Z

This PR (HEAD: a9a4e06) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/429858 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-16T04:29:52Z

Message from DeJiang Zhu (doujiang):

Patch Set 5: Code-Review+1

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-20T01:41:08Z

Message from DeJiang Zhu (doujiang):

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-24T02:15:28Z

Message from xie cui:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-24T02:23:42Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-24T02:27:45Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-24T11:15:48Z

This PR (HEAD: 7bbfddb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/429858 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-24T11:28:46Z

Message from DeJiang Zhu (doujiang):

Patch Set 6: -Code-Review

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-24T11:28:47Z

Message from xie cui:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-24T11:33:13Z

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-26T11:11:41Z

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-26T16:12:40Z

Message from Michael Pratt:

Patch Set 6: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-27T00:53:56Z

Message from DeJiang Zhu (doujiang):

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-27T16:40:29Z

Message from Michael Pratt:

Patch Set 6: Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/429858.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-27T16:45:48Z

This PR is being closed because golang.org/cl/429858 has been merged.

Extra Ms may lead to the "no consistent ordering of events possible" error when parsing trace file with cgo enabled, since: 1. The gs in the extra Ms may be in `_Gdead` status while starting trace by invoking `runtime.StartTrace`, 2. and these gs will trigger `traceEvGoSysExit` events in `runtime.exitsyscall` when invoking go functions from c, 3. then, the events of those gs are under non-consistent ordering, due to missing the previous events. Add two events, `traceEvGoCreate` and `traceEvGoInSyscall`, in `runtime.StartTrace`, will make the trace parser happy. Fixes #29707 Change-Id: I2fd9d1713cda22f0ddb36efe1ab351f88da10881 GitHub-Last-Rev: 7bbfddb GitHub-Pull-Request: #54974 Reviewed-on: https://go-review.googlesource.com/c/go/+/429858 Run-TryBot: Michael Pratt <[email protected]> Reviewed-by: Michael Pratt <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Run-TryBot: xie cui <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Michael Pratt <[email protected]>

doujiang24 changed the title ~~wip: runtime/trace: add missing events for the locked g in extra M.~~ runtime/trace: add missing events for the locked g in extra M. Sep 9, 2022

doujiang24 added 6 commits September 11, 2022 00:09

fix trace: no consistent ordering.

e4ac214

removed the uint64 cast.

7badcd1

upload to a file server when parse failed.

6d46007

init sysblocktraced = true for dead lock g in extra M.

dd5c16e

test with GOMAXPROCS=1.

9f7bb22

removed the debug code.

12e687f

added the TraceParser suffix, to avoid conflict.

4814eee

doujiang24 force-pushed the fix-trace branch from 2f65d45 to 4814eee Compare September 10, 2022 16:16

doujiang24 added 2 commits September 13, 2022 09:33

minor fix.

a995d1e

split test.

ebe3b9f

addressed comments.

a9a4e06

fixed tests.

7bbfddb

gopherbot closed this Sep 27, 2022

runtime/trace: add missing events for the locked g in extra M. #54974

runtime/trace: add missing events for the locked g in extra M. #54974

Conversation

doujiang24 commented Sep 9, 2022 • edited Loading

gopherbot commented Sep 9, 2022

gopherbot commented Sep 9, 2022

gopherbot commented Sep 10, 2022

gopherbot commented Sep 10, 2022

gopherbot commented Sep 10, 2022

gopherbot commented Sep 10, 2022

gopherbot commented Sep 10, 2022

gopherbot commented Sep 10, 2022

gopherbot commented Sep 10, 2022

gopherbot commented Sep 10, 2022

gopherbot commented Sep 12, 2022

gopherbot commented Sep 12, 2022

gopherbot commented Sep 12, 2022

gopherbot commented Sep 12, 2022

gopherbot commented Sep 12, 2022

gopherbot commented Sep 12, 2022

gopherbot commented Sep 13, 2022

gopherbot commented Sep 13, 2022

gopherbot commented Sep 15, 2022

gopherbot commented Sep 15, 2022

gopherbot commented Sep 16, 2022

gopherbot commented Sep 16, 2022

gopherbot commented Sep 20, 2022

gopherbot commented Sep 24, 2022

gopherbot commented Sep 24, 2022

gopherbot commented Sep 24, 2022

gopherbot commented Sep 24, 2022

gopherbot commented Sep 24, 2022

gopherbot commented Sep 24, 2022

gopherbot commented Sep 24, 2022

gopherbot commented Sep 26, 2022

gopherbot commented Sep 26, 2022

gopherbot commented Sep 27, 2022

gopherbot commented Sep 27, 2022

gopherbot commented Sep 27, 2022

doujiang24 commented Sep 9, 2022 •

edited

Loading