go/printer: make ExampleFprint correctly run as online example #53141
Conversation
SilverRainZ
force-pushed
the
fix-go-printer-sandbox-example
branch
from
18baac2
to
721e999
Compare
|
This PR (HEAD: 721e999) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/409314 to see it. Tip: You can toggle comments from me using the |
|
Message from Daniel Martí: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
|
Message from 张盛宇: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
|
Message from Daniel Martí: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
|
Message from 张盛宇: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
SilverRainZ
force-pushed
the
fix-go-printer-sandbox-example
branch
from
721e999
to
6d0a580
Compare
|
This PR (HEAD: 6d0a580) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/409314 to see it. Tip: You can toggle comments from me using the |
|
Message from 张盛宇: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
|
Message from Daniel Martí: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
function "ExampleFprint" will be rewritten to function "main"
when displayed on the godoc pages, so the online example is failed to
run:
Output:
panic: function not found
goroutine 1 [running]:
main.parseFunc({0x4f772e, 0xf}, {0x4f713f, 0xd})
/tmp/sandbox1264544227/prog.go:23 +0x13b
main.main()
/tmp/sandbox1264544227/prog.go:30 +0x45
See: https://pkg.go.dev/go/printer#example-Fprint
Add printSelf function to prevent the function not found when running in godoc
sandbox. Beside, deleting the dummy test function to make the example show
the entire file, as we want to show the newly added printSelf function.
SilverRainZ
force-pushed
the
fix-go-printer-sandbox-example
branch
from
6d0a580
to
bac1189
Compare
|
This PR (HEAD: bac1189) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/409314 to see it. Tip: You can toggle comments from me using the |
|
Message from 张盛宇: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
SilverRainZ
changed the title
|
Message from Bryan Mills: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
|
Message from Daniel Martí: Patch Set 4: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
|
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
|
Message from Heschi Kreinick: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
|
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/409314. |
function "ExampleFprint" will be rewritten to function "main"
when displayed on the godoc pages, so the online example is failed to
run:
Output:
panic: function not found
goroutine 1 [running]:
main.parseFunc({0x4f772e, 0xf}, {0x4f713f, 0xd})
/tmp/sandbox1264544227/prog.go:23 +0x13b
main.main()
/tmp/sandbox1264544227/prog.go:30 +0x45
See: https://pkg.go.dev/go/printer#example-Fprint
Add printSelf function to prevent the function not found when running in godoc
sandbox. Beside, deleting the dummy test function to make the example show
the entire file, as we want to show the newly added printSelf function.
Change-Id: Ia2b772937081b58a0fce9860838959c95f2d650c
GitHub-Last-Rev: bac1189
GitHub-Pull-Request: #53141
Reviewed-on: https://go-review.googlesource.com/c/go/+/409314
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Daniel Martí <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>
|
This PR is being closed because golang.org/cl/409314 has been merged. |
function "ExampleFprint" will be rewritten to function "main"
when displayed on the godoc pages, so the online example is failed to
run:
See: https://pkg.go.dev/go/printer#example-Fprint
Add printSelf function to prevent the function not found when running in godoc
sandbox. Beside, deleting the dummy test function to make the example show
the entire file, as we want to show the newly added printSelf function.