Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: check amd64 microarchitecture level at startup #48514

Closed
wants to merge 4 commits into from
Closed

runtime: check amd64 microarchitecture level at startup #48514

wants to merge 4 commits into from

Conversation

vpachkov
Copy link
Contributor

@vpachkov vpachkov commented Sep 21, 2021 •
edited
Loading

Make Go runtime throw if it's been compiled to assume instruction
set extensions that aren't available on the CPU.
Updates #48506

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 21, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 7250e5b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@vpachkov vpachkov changed the title runtime: check a microarchitecture level at startup cmd/{compile,link}, runtime: check a microarchitecture level at startup Sep 21, 2021
@gopherbot
Copy link
Contributor

Message from Cherry Mui:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Dempsky:

Patch Set 2: Code-Review-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Dempsky:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@vpachkov vpachkov changed the title cmd/{compile,link}, runtime: check a microarchitecture level at startup runtime: check amd64 microarchitecture level at startup Sep 24, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: e5c29d2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 513632d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 4:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 9c24149) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: b6a6c17) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 8f0adf1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: b9704be) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Matthew Dempsky:

Patch Set 9:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Dempsky:

Patch Set 9: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 9: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@vpachkov vpachkov force-pushed the microarch-checking branch from b9704be to 5c9be39 Compare October 7, 2021 08:12
@gopherbot
Copy link
Contributor

This PR (HEAD: 5c9be39) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 504b187) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 17:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 17: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 17:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 17:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 17:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 17: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e4ca98b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 18:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 18: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 18:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 18:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 18: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 18:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: ba33837) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/351191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 19:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 19: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 19:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 19: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 19: Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 19:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 19:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/351191.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 2, 2021
@vpachkov @randall77
runtime: check amd64 microarchitecture level at startup
8c8baad 
Make Go runtime throw if it's been compiled to assume instruction
set extensions that aren't available on the CPU.
Updates #48506

Change-Id: Ic4d6696e1cd6b28d389a86fe64e8175ea3ca135a
GitHub-Last-Rev: ba33837
GitHub-Pull-Request: #48514
Reviewed-on: https://go-review.googlesource.com/c/go/+/351191
Run-TryBot: Martin Möhrmann <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Martin Möhrmann <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Trust: Martin Möhrmann <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/351191 has been merged.

@gopherbot gopherbot closed this Nov 2, 2021
@gabyhelp gabyhelp mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vpachkov @gopherbot