-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/internal/load: fix bad error message for local imports in module mode #47516
base: master
Are you sure you want to change the base?
Conversation
mode In module mode, if an import statement refers to a relative path it is currently supposed to fail with relative import not supported However, we seem to be missing test coverage for that error message, and the actual error that is printed for that case is substantially different
This PR (HEAD: 9c9b32f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/339409 to see it. Tip: You can toggle comments from me using the |
Message from Bryan C. Mills: Patch Set 2: Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
This PR (HEAD: 2683904) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/339409 to see it. Tip: You can toggle comments from me using the |
Message from Yuki Osaki: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 3: Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
This PR (HEAD: e166048) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/339409 to see it. Tip: You can toggle comments from me using the |
Message from Yuki Osaki: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 4: Run-TryBot+1 Code-Review+1 Trust+1 (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 4: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
This PR (HEAD: e259b56) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/339409 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 3b7b85e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/339409 to see it. Tip: You can toggle comments from me using the |
Message from Yuki Osaki: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Yuki Osaki: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Yuki Osaki: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 7: Patch Set 6 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 7: Run-TryBot+1 Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 7: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Jay Conrod: Patch Set 7: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 8: Patch Set 7 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Yuki Osaki: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Yuki Osaki: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 7: Patch Set 6 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 7: Run-TryBot+1 Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 7: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Jay Conrod: Patch Set 7: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 8: Patch Set 7 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 8: Run-TryBot+1 Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 8: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 8: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 9: Patch Set 8 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 9: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 9: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 10: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 10: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 11: Patch Set 10 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Bryan C. Mills: Patch Set 11: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 11: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 11: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
Message from Go Bot: Patch Set 11: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/339409. |
In module mode, if an import statement refers to a relative path it is
currently supposed to fail with relative import not supported
However, we seem to be missing test coverage for that error message,
and the actual error that is printed for that case is substantially different
Fixes #47088