New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: add Unwrap to SystemRootsError #41981

Closed

psampaz wants to merge 1 commit into golang:master from psampaz:crypto-x509-SystemRootsError-upwrap

Contributor

psampaz commented Oct 14, 2020

This change modifies Go to add the Unwrap method to SystemRootsError

Updates #30322


          Add Unwrap to SystemRootsError

9a95bc6

google-cla bot added the cla: yes label

Contributor

gopherbot commented Oct 14, 2020

This PR (HEAD: 9a95bc6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/262343 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Oct 14, 2020

Message from Damien Neil:

Patch Set 1: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262343.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 14, 2020

Message from Damien Neil:

Patch Set 1: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/262343.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 16, 2020

Message from Filippo Valsorda:

Patch Set 1: Run-TryBot+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262343.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 16, 2020

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=79fd3df4

Please don’t reply on this GitHub thread. Visit golang.org/cl/262343.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 16, 2020

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/262343.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          crypto/x509: add Unwrap to SystemRootsError

f7ef5ca

This change modifies Go to add the Unwrap method to SystemRootsError

Updates #30322

Change-Id: Ibe63d1d0bc832fc0607f09053908d55275a6f350
GitHub-Last-Rev: 9a95bc6
GitHub-Pull-Request: #41981
Reviewed-on: https://go-review.googlesource.com/c/go/+/262343
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Filippo Valsorda <[email protected]>
Trust: Damien Neil <[email protected]>
Run-TryBot: Filippo Valsorda <[email protected]>
TryBot-Result: Go Bot <[email protected]>

Contributor

gopherbot commented Nov 7, 2020

This PR is being closed because golang.org/cl/262343 has been merged.

gopherbot closed this

bassosimone pushed a commit to ooni/oocrypto that referenced this pull request


          crypto/x509: add Unwrap to SystemRootsError

d619076

This change modifies Go to add the Unwrap method to SystemRootsError

Updates #30322

Change-Id: Ibe63d1d0bc832fc0607f09053908d55275a6f350
GitHub-Last-Rev: 9a95bc66019d25f02a0a5f92a87e9405a52802e4
GitHub-Pull-Request: golang/go#41981
Reviewed-on: https://go-review.googlesource.com/c/go/+/262343
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Filippo Valsorda <[email protected]>
Trust: Damien Neil <[email protected]>
Run-TryBot: Filippo Valsorda <[email protected]>
TryBot-Result: Go Bot <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels