runtime: call osyield directly in lockextra #36078
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: 7a0aa25) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/210837 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=1d1b87b4 Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Ian Lance Taylor: Patch Set 2: Patch Set 1 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Ian Lance Taylor: Patch Set 2: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Gobot Gobot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=7e501e81 Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Gobot Gobot: Patch Set 2: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Gobot Gobot: Patch Set 2: TryBot-Result-1 1 of 20 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Ian Lance Taylor: Patch Set 2:
Trybot error is #38440. Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Ian Lance Taylor: Patch Set 3: Patch Set 2 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Ian Lance Taylor: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=77d82a52 Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
|
Message from Gobot Gobot: Patch Set 3: TryBot-Result-1 1 of 20 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/210837. |
The `yield := osyield` line doesn't serve any purpose, it's committed in `2015`, time to delete that line:) Change-Id: I382d4d32cf320f054f011f3b6684c868cbcb0ff2 GitHub-Last-Rev: 7a0aa25 GitHub-Pull-Request: #36078 Reviewed-on: https://go-review.googlesource.com/c/go/+/210837 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
|
This PR is being closed because golang.org/cl/210837 has been merged. |
The
yield := osyieldline doesn't serve any purpose, it's committed in2015, time to delete that line:)