Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: wrong require when migrate from dep with source config #33343

Closed
wants to merge 1 commit into from
Closed

mod: wrong require when migrate from dep with source config #33343

wants to merge 1 commit into from

Conversation

liuchang0812
Copy link

This change modifies Go to generate correct go.mod file.
Currently go-mod puts wrong module path in requires when
Gopkg.toml contains source config. for example, there is
a constraint declaration in Gopkg.toml as following:

[[constraint]]
  name = "github.com/minio/minio-go"
  revision = "0415038e6086735b8c917d7fdb2ca93f07d7fb60"
  source = "https://github.com/liuchang0812/minio-go"

go-mod puts github.com/liuchang0812/minio-go in requires.
but, it should be github.com/minio/minio-go

Signed-off-by: Chang Liu [email protected]

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 29, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 5774b90) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/187959 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187959.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 1:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/187959.
After addressing review feedback, remember to publish your drafts!

This change modifies Go to generate correct go.mod file.
Currently go-mod puts wrong module path in requires when
Gopkg.toml contains source config. for example, there is
a constraint declaration in Gopkg.toml as following:

[[constraint]]
  name = "github.com/minio/minio-go"
  revision = "0415038e6086735b8c917d7fdb2ca93f07d7fb60"
  source = "https://github.com/liuchang0812/minio-go"

go-mod puts `github.com/liuchang0812/minio-go` in requires.
but, it should be `github.com/minio/minio-go`

Fixes: #33406
@gopherbot
Copy link
Contributor

This PR (HEAD: 96fae32) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/187959 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Chang Liu:

Patch Set 1:

(6 comments)

Thank you very much.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187959.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Chang Liu:

Patch Set 2:

(1 comment)

I added a test case. https://github.com/liuchang0812/supreme-octo-memory is a go-dep project whose Gopkg.toml contains a source conf. convert_test.go will verify whether go-mod-in generates go.mod as expected.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187959.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2:

(3 comments)

Please also update the existing test in src/cmd/go/testdata/script/mod_init_dep.txt and ensure that it passes.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187959.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Chang Liu:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/187959.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/187959.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187959.
After addressing review feedback, remember to publish your drafts!

@heschi heschi closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants