-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http/httputil: remove all fields in Connection header #30687
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: d553c58) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/166298 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/166298. |
Message from Emmanuel Odeke: Patch Set 1: (3 comments) Thank you for working on this change Jonathon! I've added some suggestions but it is important that we keep a mix of the old tests e.g. comma separated header values and also add new ones using header.Add Please don’t reply on this GitHub thread. Visit golang.org/cl/166298. |
Message from Emmanuel Odeke: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/166298. |
This PR (HEAD: 9fabaec) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/166298 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 9c70906) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/166298 to see it. Tip: You can toggle comments from me using the |
Message from Brad Fitzpatrick: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/166298. |
This PR (HEAD: b410381) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/166298 to see it. Tip: You can toggle comments from me using the |
Message from Brad Fitzpatrick: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/166298. |
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=57b6ab2b Please don’t reply on this GitHub thread. Visit golang.org/cl/166298. |
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/166298. |
In the reverseproxy, replace use (Header).Get, which returns only one value of a multiple value header, with using the Header map directly. Also fixes corresponding tests which hid the bug, and adds more tests. Fixes #30303 Change-Id: Ic9094b5983043460697748759f6dfd95fc111db7 GitHub-Last-Rev: b410381 GitHub-Pull-Request: #30687 Reviewed-on: https://go-review.googlesource.com/c/go/+/166298 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
This PR is being closed because golang.org/cl/166298 has been merged. |
In the reverseproxy, replace use (Header).Get, which returns only one value
of a multiple value header, with using the Header map directly. Also fixes
corresponding tests which hid the bug, and adds more tests.
Fixes #30303