Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/test: pass default timeout to test programs if not given from command line #30545

Closed
wants to merge 1 commit into from

Conversation

okamotoyuki
Copy link
Contributor

Make 'go test' command to pass the default timeout (10m) to test programs if the value is not given from command line.

Fixes #28147

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Mar 3, 2019
@okamotoyuki
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Mar 3, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 8d5fff1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/164963 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1:

(2 comments)

Thanks for the fix! A couple of minor comments.


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: ae998de) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/164963 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Yuki Okamoto:

Patch Set 2:

(2 comments)

Patch Set 1:

(2 comments)

Thanks for the fix! A couple of minor comments.

Thanks for your prompt review!
I just updated the pull request based on your review.


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 2: Run-TryBot+1 Code-Review+1

Nice, thank you Yuki!

Bryan I am just running the tests, merging all yours.


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=54991d2a


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

Build is still in progress...
This change failed on linux-amd64:
See https://storage.googleapis.com/go-build-log/54991d2a/linux-amd64_6e07ca85.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result-1

2 of 19 TryBots failed:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/54991d2a/linux-amd64_6e07ca85.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/54991d2a/windows-amd64-2016_ae1365df.log

Consult https://build.golang.org/ to see whether they are new failures.


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Yuki Okamoto:

Patch Set 2:

Patch Set 1:

(2 comments)

Thanks for the fix! A couple of minor comments.

Hi Bryan!

I applied the fixes but it seemed to break a few tests on some platforms unfortunately.

Let me confirm if my understanding is correct.

'testKillTimeout' is just a backup alarm as described in the following comment.

Then, 'dt' itself in the following code (which is originally specified with '-timeout' option) should be passed to test programs as 'test.timeout' flag, right?

Cheers,
Yuki


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

…t is not given from command line

Make 'go test' command to pass the default timeout (10m) to test programs even if the value is not given from command line.

Fixes golang#28147
@gopherbot
Copy link
Contributor

This PR (HEAD: 66f9a6f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/164963 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 3: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=427c525d


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3:

Build is still in progress...
This change failed on misc-vet-vetall:
See https://storage.googleapis.com/go-build-log/427c525d/misc-vet-vetall_2eddc49b.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 4: Patch Set 3 was rebased


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 4: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e6a864b3


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3: TryBot-Result-1

1 of 19 TryBots failed:
Failed on misc-vet-vetall: https://storage.googleapis.com/go-build-log/427c525d/misc-vet-vetall_2eddc49b.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/164963.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 13, 2019
…ven from command line

Make 'go test' command to pass the default timeout (10m) to test programs if the value is not given from command line.

Fixes #28147

Change-Id: I7856e452224a51a92da03bab8e3a0f9d7c41d32a
GitHub-Last-Rev: 66f9a6f
GitHub-Pull-Request: #30545
Reviewed-on: https://go-review.googlesource.com/c/go/+/164963
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/164963 has been merged.

@gopherbot gopherbot closed this Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd/go: when -timeout is the default (10m), pass a nonzero -test.timeout to tests
3 participants