-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/elliptic: generalize elliptic.Curve to allow A != -3 #26873
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Confirm I'm ok with my commits being contributed to this project! |
When merge? |
Do we need to override the |
Looks like the proposal issue was declined. Leaving it up to @FiloSottile to decide what to do here, but I assume we can just close this PR. |
I went ahead and pulled the code from the PR out and put a usable version here (tests and example included): https://github.com/eliwjones/crypto The main secp256k1 stuff I see out and about are wrappers of C code. I have not seen a satisfactorily trustworthy native Go implementation.. so, if anyone knows of one, please post it here. Linking to issue thread as well: |
53bd915
to
6139019
Compare
4a7ed1f
to
0f992b9
Compare
The subject proposal/issue was closed in #26776 (comment), thus closing this PR too. We appreciate your contributions to the Go project @collinc97, and look forward to interacting with you even more in the future. Thank you. |
Fixes #26776