Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/elliptic: generalize elliptic.Curve to allow A != -3 #26873

Closed
wants to merge 9 commits into from

Conversation

collinc97
Copy link

Fixes #26776

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Aug 8, 2018
@collinc97
Copy link
Author

I signed it!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@cag
Copy link

cag commented Aug 8, 2018

Confirm I'm ok with my commits being contributed to this project!

@Hirama
Copy link

Hirama commented Apr 10, 2019

When merge?

@shazow
Copy link
Contributor

shazow commented May 21, 2019

Do we need to override the cla:no label here somehow to get it reviewed?

@mvdan
Copy link
Member

mvdan commented Aug 29, 2019

Looks like the proposal issue was declined. Leaving it up to @FiloSottile to decide what to do here, but I assume we can just close this PR.

@eliwjones
Copy link

I went ahead and pulled the code from the PR out and put a usable version here (tests and example included):

https://github.com/eliwjones/crypto

The main secp256k1 stuff I see out and about are wrappers of C code.

I have not seen a satisfactorily trustworthy native Go implementation.. so, if anyone knows of one, please post it here.

Linking to issue thread as well:
#26776 (comment)

@odeke-em
Copy link
Member

The subject proposal/issue was closed in #26776 (comment), thus closing this PR too. We appreciate your contributions to the Go project @collinc97, and look forward to interacting with you even more in the future. Thank you.

@odeke-em odeke-em closed this Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: crypto/elliptic: add A to CurveParams, allowing some cases of A != -3
8 participants