-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: check test cache more efficiently #26732
Conversation
Before this change, the same hashes were being computed multiple times in some cases. This gets the case reported in issue golang#26726 down from over 30s to .8s.
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/127155. |
Message from Gerrit User 10961: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/127155. |
Message from Gerrit User 28552: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/127155. |
Message from Gerrit User 12446: Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2. Please don’t reply on this GitHub thread. Visit golang.org/cl/127155. |
Message from Gerrit User 10961: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127155. |
Message from Gerrit User 28552: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/127155. |
Message from Gerrit User 28552: Patch Set 3: I got good results by removing the EvalSymlinks calls from inDir as suggested by rsc in #26562. I'm thinking it will be best to revert this change and make a new one. Please don’t reply on this GitHub thread. Visit golang.org/cl/127155. |
This PR is being closed because golang.org/cl/127155 has been abandoned. |
Fixes #26726
Before this change, the same hashes were being computed multiple times
in some cases.
This gets the case reported in issue #26726 down from over 30s to .8s.