Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/pprof: coroutines + pprof makes the program panic [1.23 backport] #70001

Closed
gopherbot opened this issue Oct 23, 2024 · 2 comments · Fixed by thanos-io/thanos#7891
Closed

net/http/pprof: coroutines + pprof makes the program panic [1.23 backport] #70001

gopherbot opened this issue Oct 23, 2024 · 2 comments · Fixed by thanos-io/thanos#7891
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.23.3

Comments

@gopherbot
Copy link
Contributor

@mknyszek requested issue #69998 to be considered for backport to the next 1.23 minor release.

@gopherbot Please open a backport issue for Go 1.23.

This causes crashes with no workaround when trying to take a goroutine profile in a program that uses iter.Pull. This problem only applies to that release because it pertains to the new iter package.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 23, 2024
@gopherbot gopherbot mentioned this issue Oct 23, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 23, 2024
@gopherbot gopherbot added this to the Go1.23.3 milestone Oct 23, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/622375 mentions this issue: [release-branch.go1.23] runtime: uphold goroutine profile invariants in coroswitch

@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Oct 30, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 30, 2024
gopherbot pushed a commit that referenced this issue Oct 30, 2024
@mknyszek @prattmic
[release-branch.go1.23] runtime: uphold goroutine profile invariants …
cfe0ae0 
…in coroswitch

Goroutine profiles require checking in with the profiler before any
goroutine starts running. coroswitch is a place where a goroutine may
start running, but where we do not check in with the profiler, which
leads to crashes. Fix this by checking in with the profiler the same way
execute does.

For #69998.
Fixes #70001.

Change-Id: Idef6dd31b70a73dd1c967b56c307c7a46a26ba73
Reviewed-on: https://go-review.googlesource.com/c/go/+/622016
Reviewed-by: David Chase <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
(cherry picked from commit 2a98a18)
Reviewed-on: https://go-review.googlesource.com/c/go/+/622375
Reviewed-by: Michael Pratt <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 622375 (commit cfe0ae0) to release-branch.go1.23.

GiedriusS added a commit to thanos-io/thanos that referenced this issue Nov 7, 2024
@GiedriusS
*: bump Go version
b9e70fe 
Use 1.23.3 as it contains a critical fix: golang/go#70001

Signed-off-by: Giedrius Statkevičius <[email protected]>
@GiedriusS GiedriusS mentioned this issue Nov 7, 2024
Merged
GiedriusS added a commit to thanos-io/thanos that referenced this issue Nov 7, 2024
@GiedriusS
*: bump Go version (#7891)
928bc7a 
Use 1.23.3 as it contains a critical fix: golang/go#70001

Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.23.3
Development

Successfully merging a pull request may close this issue.

*: bump Go version thanos-io/thanos
2 participants
@prattmic @gopherbot