Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: remove the "allowImplicitNetworkAccess" setting #66861

Closed
findleyr opened this issue Apr 16, 2024 · 3 comments
Closed

x/tools/gopls: remove the "allowImplicitNetworkAccess" setting #66861

findleyr opened this issue Apr 16, 2024 · 3 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.17.0

Comments

@findleyr
Copy link
Member

Following up on #66860, this issue tracks removing the "allowImplicitNetworkAccess" setting. As stated on that issue:

We should not have settings that affect low level behavior like this, as such settings are inevitably insufficiently tested and hard to maintain. Gopls should work well with its default decisions about allowing network access

If you are here because you use this setting and received a warning that it will be removed, please explain why you use it!
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 16, 2024
@gopherbot gopherbot added this to the Unreleased milestone Apr 16, 2024
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.17.0 Apr 16, 2024
@nikzayn
Copy link

nikzayn commented Jun 22, 2024

@findleyr can I take this up?

@findleyr
Copy link
Member Author

@nikzayn sorry but this is really just a process issue, not a good candidate for contribution.

L3n41c added a commit to DataDog/datadog-agent that referenced this issue Jun 28, 2024
@L3n41c
Get rid of allowImplicitNetworkAccess because it’s deprecated
3e1e3d3 
golang/go#66861
@findleyr findleyr self-assigned this Oct 22, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/621877 mentions this issue: gopls/internal/settings: remove "allowImplicitNetworkAccess"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.17.0
Development

No branches or pull requests
3 participants
@gopherbot @nikzayn @findleyr