Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: http2 page fails on firefox/safari if pushing resources [1.20 backport] #63740

Closed
neild opened this issue Oct 25, 2023 · 3 comments
Closed

net/http: http2 page fails on firefox/safari if pushing resources [1.20 backport] #63740

neild opened this issue Oct 25, 2023 · 3 comments
Assignees
@mauri870
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.20.11

Comments

@neild
Copy link
Contributor

neild commented Oct 25, 2023

Backport #63511 to the next 1.20 minor release. This is a regression with no workaround.
@neild neild added the CherryPickApproved Used during the release process for point releases label Oct 25, 2023
@neild neild added this to the Go1.20.11 milestone Oct 25, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/538095 mentions this issue: [release-branch.go1.20] net/http: pull http2 underflow fix from x/net/http2

@mauri870 mauri870 self-assigned this Oct 26, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/537956 mentions this issue: [internal-branch.go1.20-vendor] http2: fix underflow in http2 server push

gopherbot pushed a commit to golang/net that referenced this issue Oct 27, 2023
@mauri870 @gopherbot
[internal-branch.go1.20-vendor] http2: fix underflow in http2 server …
b8c2abf 
…push

After CL 534215 was merged to fix a CVE it introduced
an underflow when we try to decrement sc.curHandlers
in handlerDone.

The func startPush calls runHandler without incrementing
curHandlers. Seems to only affect users of http.Pusher.

For golang/go#63511
For golang/go#63740

Change-Id: Ic537c27c9945c2c2d4306ddb04e9527b65cee320
GitHub-Last-Rev: 249fe55
GitHub-Pull-Request: #197
Reviewed-on: https://go-review.googlesource.com/c/net/+/535595
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Mauri de Souza Meneguzzo <[email protected]>
(cherry picked from commit 37479d6)
Reviewed-on: https://go-review.googlesource.com/c/net/+/537956
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
gopherbot pushed a commit that referenced this issue Oct 30, 2023
@mauri870 @cherrymui
[release-branch.go1.20] net/http: pull http2 underflow fix from x/net…
998fdce 
…/http2

After CL 534295 was merged to fix a CVE it introduced
an underflow when we try to decrement sc.curHandlers
in handlerDone.

Pull in a fix from x/net/http2:
http2: fix underflow in http2 server push
https://go-review.googlesource.com/c/net/+/535595

For #63511
Fixes #63740

Change-Id: I5c678ce7dcc53635f3ad5e4999857cb120dfc1ab
GitHub-Last-Rev: 587ffa3
GitHub-Pull-Request: #63561
Reviewed-on: https://go-review.googlesource.com/c/go/+/535575
Run-TryBot: Mauri de Souza Meneguzzo <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: David Chase <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
(cherry picked from commit 0046c14)
Reviewed-on: https://go-review.googlesource.com/c/go/+/538095
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
@gopherbot
Copy link
Contributor

Closed by merging 998fdce to release-branch.go1.20.

@golang golang locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mauri870 mauri870

Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.20.11
Development

No branches or pull requests
3 participants
@neild @gopherbot @mauri870