-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: connecting to 0.0.0.0 fails on windows #6290
Comments
Let's at least remove that example from the docs on the |
The doc says: |
#10624 will update the documentation; It will probably have a section about "Network and host/address arguments." |
Binding plugins to a TCP port on localhost using ServeTCP("foo", ":12345") does not work on Windows. This is because the golang net package does not handle empty hostname/IP. golang/go#6290 tracks it and is slated to be fixed in Go 1.8. This change explicitly adds "localhost" if there's no hostname and serve as a workaround until Golang fixes it. Signed-off-by: Anusha Ragunathan <[email protected]>
CL https://golang.org/cl/31950 mentions this issue. |
I think we should fix this. We advertise that Dial(":80") connects to the local system's port 80. It should do that on Windows too. I'll send a CL with a test and a fix; criticisms welcome. |
CL https://golang.org/cl/32101 mentions this issue. |
updated proxy protocol tests to work in windows with golang < 1.8 for reference: the inconsistency was documented in golang/go#6290 and was fixed with golang/go@1a0b1cc
The text was updated successfully, but these errors were encountered: