Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link,cmd/pack: tests fail with missing Go type information for global symbol .dynsym on android/arm64 #58806

Open
bcmills opened this issue Mar 1, 2023 · 2 comments
Open

cmd/link,cmd/pack: tests fail with missing Go type information for global symbol .dynsym on android/arm64 #58806

bcmills opened this issue Mar 1, 2023 · 2 comments
Assignees
@cherrymui
Labels
arch-arm64 compiler/runtime Issues related to the Go compiler and/or runtime. mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 1, 2023

In CL 472096, I am experimenting with enabling tests that use go build on android, because I don't see a good reason not to. Unfortunately, several cmd/link tests fail when run on android/arm64, with the failure mode:

    runtime.gcdata: missing Go type information for global symbol .dynsym: size 24

(Complete log in https://storage.googleapis.com/go-build-log/c86ce876/android-arm64-corellium_04a8c6e6.log.)

(attn @golang/android @golang/compiler)
@bcmills bcmills added OS-Android NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. mobile Android, iOS, and x/mobile arch-arm64 compiler/runtime Issues related to the Go compiler and/or runtime. labels Mar 1, 2023
@bcmills bcmills added this to the Backlog milestone Mar 1, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/472455 mentions this issue: cmd/link: skip tests that fail on android/arm64

@mknyszek
Copy link
Contributor

mknyszek commented Mar 8, 2023

@cherrymui thinks it's a linker phase order thing where we create that symbol too early or with the wrong type, and a latter part of the linker thinks it needs runtime.gcdata.

@bcmills bcmills changed the title cmd/link: tests fail with missing Go type information for global symbol .dynsym on android/arm64 cmd/link,cmd/pack: tests fail with missing Go type information for global symbol .dynsym on android/arm64 Mar 9, 2023
gopherbot pushed a commit that referenced this issue Mar 10, 2023
@gopherbot
all: skip tests that fail on android/arm64
d12fe60 
Many of the tests skipped platforms that build PIE binaries by
default, but (still) lack a central function to report which platforms
those are.

Some of the tests assumed (but did not check for) internal linking
support, or invoked `go tool link` directly without properly
configuring the external linker.

A few of the tests seem to be triggering latent bugs in the linker.

For #58806.
For #58807.
For #58794.

Change-Id: Ie4d06b1597f404590ad2abf978d4c363647407ac
Reviewed-on: https://go-review.googlesource.com/c/go/+/472455
Reviewed-by: Cherry Mui <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cherrymui cherrymui

Labels
arch-arm64 compiler/runtime Issues related to the Go compiler and/or runtime. mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Projects
Go Compiler / Runtime
Status: Todo
Milestone
Backlog
Development

No branches or pull requests
4 participants
@mknyszek @bcmills @gopherbot @cherrymui