Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: some x/sys versions no longer build due to "go:linkname must refer to declared function or variable" [1.19 backport] #56557

Closed
gopherbot opened this issue Nov 3, 2022 · 2 comments
Closed

cmd/compile: some x/sys versions no longer build due to "go:linkname must refer to declared function or variable" [1.19 backport] #56557

gopherbot opened this issue Nov 3, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.4

Comments

@gopherbot
Copy link
Contributor

@mdempsky requested issue #55889 to be considered for backport to the next 1.19 minor release.

@gopherbot Please backport to Go 1.18 and 1.19. This was is regression in the Go compiler, which broke building x/sys for GOOS=darwin prior to https://go.dev/cl/274573 (golang/sys@69691e4).
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 3, 2022
@gopherbot gopherbot mentioned this issue Nov 3, 2022
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 3, 2022
@gopherbot gopherbot added this to the Go1.19.4 milestone Nov 3, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/447816 mentions this issue: [release-branch.go1.19] cmd/compile: allow ineffectual //go:linkname in -lang=go1.17 and older

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Nov 9, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 9, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging 9e0b6c1 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Nov 9, 2022
@mdempsky @mknyszek
[release-branch.go1.19] cmd/compile: allow ineffectual //go:linkname …
9e0b6c1 
…in -lang=go1.17 and older

Prior to Go 1.18, ineffectual //go:linkname directives (i.e.,
directives referring to an undeclared name, or to a declared type or
constant) were treated as noops. In Go 1.18, we changed this into a
compiler error to mitigate accidental misuse.

However, the x/sys repo contained ineffectual //go:linkname directives
up until go.dev/cl/274573, which has caused a lot of user confusion.

It seems a bit late to worry about now, but to at least prevent
further user pain, this CL changes the error message to only apply to
modules using "go 1.18" or newer. (The x/sys repo declared "go 1.12"
at the time go.dev/cl/274573 was submitted.)

For #55889.
Fixes #56557.

Change-Id: Id762fff96fd13ba0f1e696929a9e276dfcba2620
Reviewed-on: https://go-review.googlesource.com/c/go/+/447755
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Matthew Dempsky <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/447816
andrew-d pushed a commit to tailscale/go that referenced this issue Dec 7, 2022
@mdempsky @andrew-d
[release-branch.go1.19] cmd/compile: allow ineffectual //go:linkname …
b65eeb8 
…in -lang=go1.17 and older

Prior to Go 1.18, ineffectual //go:linkname directives (i.e.,
directives referring to an undeclared name, or to a declared type or
constant) were treated as noops. In Go 1.18, we changed this into a
compiler error to mitigate accidental misuse.

However, the x/sys repo contained ineffectual //go:linkname directives
up until go.dev/cl/274573, which has caused a lot of user confusion.

It seems a bit late to worry about now, but to at least prevent
further user pain, this CL changes the error message to only apply to
modules using "go 1.18" or newer. (The x/sys repo declared "go 1.12"
at the time go.dev/cl/274573 was submitted.)

For golang#55889.
Fixes golang#56557.

Change-Id: Id762fff96fd13ba0f1e696929a9e276dfcba2620
Reviewed-on: https://go-review.googlesource.com/c/go/+/447755
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Matthew Dempsky <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/447816
@golang golang locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.4
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot