x/build: update Go bootstrap on Corellium builders #54246
Comments
|
Change https://go.dev/cl/420902 mentions this issue: |
This makes builds using earlier Go bootstrap versions fail pretty clearly: % GOROOT_BOOTSTRAP=$HOME/sdk/go1.16 ./make.bash Building Go cmd/dist using /Users/rsc/sdk/go1.16. (go1.16 darwin/amd64) found packages main (build.go) and building_Go_requires_Go_1_17_or_later (notgo117.go) in /Users/rsc/go/src/cmd/dist % All the builders have Go 1.17 or later for bootstrap now except for the android corellium builders, which still need updating (#54246). We are accepting breakage on those for now. Fixes #44505. Change-Id: I12a67f42f61dba43a331cee0a150194d3e42c044 Reviewed-on: https://go-review.googlesource.com/c/go/+/420902 Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Austin Clements <[email protected]> Run-TryBot: Russ Cox <[email protected]>
dmitshur
added
the
NeedsInvestigation
|
CC @golang/release. |
This makes builds using earlier Go bootstrap versions fail pretty clearly: % GOROOT_BOOTSTRAP=$HOME/sdk/go1.16 ./make.bash Building Go cmd/dist using /Users/rsc/sdk/go1.16. (go1.16 darwin/amd64) found packages main (build.go) and building_Go_requires_Go_1_17_or_later (notgo117.go) in /Users/rsc/go/src/cmd/dist % All the builders have Go 1.17 or later for bootstrap now except for the android corellium builders, which still need updating (golang#54246). We are accepting breakage on those for now. Fixes golang#44505. Change-Id: I12a67f42f61dba43a331cee0a150194d3e42c044 Reviewed-on: https://go-review.googlesource.com/c/go/+/420902 Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Austin Clements <[email protected]> Run-TryBot: Russ Cox <[email protected]>
|
I am investigating this. |
dmitshur
added
NeedsFix
|
It looks like these builders are now using a Go 1.18.3 bootstrap (up from Go 1.15.3), and passing:
Thanks very much for resolving this. |
|
Change https://go.dev/cl/422996 mentions this issue: |
|
The Android builders are now using Go 1.18.3, as @dmitshur noted above. I reconfigured one iOS builder to use Go 1.19 because this builder was removed by Corellium due to their VM reallocation. Let me know if it is necessary to have all Android and iOS builders use the same 1.19 version as bootstrap. |
I think it's fine for the Android and iOS builders to use slightly different bootstrap versions, given they're all meeting the hard requirement of being at minimum 1.17+. I wouldn't worry about redoing them to be exactly the same versions. In the future after #54265, it's also fine to stay closer to version specified in the |
We are going to require Go 1.17 for building Go 1.20 (see #44505).
On most builders we will have the buildlet download the right toolchain automatically.
The Corellium builders do not seem to be able to download from storage.googleapis.com: I get 403 Forbidden.
The ios builder has a toolchain at d6c4583, between Go 1.17 and Go 1.18, which is fine.
The android builder has Go 1.15.3 and will stop building soon.
Can you please update the android builder to Go 1.17 or later?
If you update it to Go 1.19 it might be a good idea to update the ios builder to match
and to get it onto a tagged release, even though it doesn't strictly need an update.
/cc @steeve and @changkun who are listed as the owners of these builders in x/build/dashboard/builders.go.
The text was updated successfully, but these errors were encountered: