x/build/cmd/relui: workflow parameters of slice types aren't visibly shown

[dmitshur]

relui currently renders a recent "announce-and-tweet-minor" workflow from the Go 1.18.5 and 1.17.13 minor release:

The values for the string parameters "Version", "Security Summary", etc., are displayed, but not for the "Release Coordinator Names" and "Security Fixes" parameters, likely because their type is []string.

(The parameter values are there in the database and were correctly used by the tasks; this is only a presentation issue.)

CC @golang/release, @cherrymui.

[dmitshur]

Looked at this briefly. As expected, it was only a problem for non-string parameters, and it's because the current parameter display code assumes all parameters are strings, which isn't always the case as of #51191.

Long term, we could extend the nice type-specific presentation that @toothrot did for results and outputs in #53382 to parameters too, but for now I'll mail a small CL that shows their JSON encoding, which is much better than invisible.

[gopherbot]

Change https://go.dev/cl/422554 mentions this issue: internal/relui: display parameters, even if their type isn't string

[toothrot]

This change breaks the layout a bit for some workflows. I am happy to fix it, though, and give it a little nicer visual treatment.

https://build.golang.org/releases/workflows/14dad363-ab84-41b7-af65-1928299f3390

[dmitshur]

Sure, thanks for helping!

[toothrot]

I'll send a CL that implements this screenshot. It's not perfect, but it's closer to something nice.

[gopherbot]

Change https://go.dev/cl/422599 mentions this issue: internal/relui: fix layout for large parameters

[gopherbot]

Change https://go.dev/cl/443059 mentions this issue: internal/relui: remove workflowParams