Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http2: timeout waiting for Write in handler in TestServer_Response_RST_Unblocks_LargeWrite #53160

Closed
bcmills opened this issue May 31, 2022 · 2 comments
Closed

net/http2: timeout waiting for Write in handler in TestServer_Response_RST_Unblocks_LargeWrite #53160

bcmills opened this issue May 31, 2022 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented May 31, 2022 

--- FAIL: TestServer_Response_RST_Unblocks_LargeWrite (2.34s)
    server_test.go:2680: Error in handler: timeout waiting for Write in handler
    server_test.go:261: Framer read log:
        2022-05-28 12:35:04.365715655 Framer 0x400056c0e0: read SETTINGS len=24, settings: MAX_FRAME_SIZE=1048576, MAX_CONCURRENT_STREAMS=250, MAX_HEADER_LIST_SIZE=1048896, INITIAL_WINDOW_SIZE=1048576
        2022-05-28 12:35:04.365982786 Framer 0x400056c0e0: read WINDOW_UPDATE len=4 (conn) incr=983041
        2022-05-28 12:35:04.367350193 Framer 0x400056c0e0: read SETTINGS flags=ACK len=0
        2022-05-28 12:35:04.371225909 Framer 0x400056c0e0: read SETTINGS flags=ACK len=0
        2022-05-28 12:35:06.624451923 Framer 0x400056c0e0: read HEADERS flags=END_HEADERS stream=1 len=25
    server_test.go:267: Framer write log:
        2022-05-28 12:35:04.362434078 Framer 0x400056c0e0: wrote SETTINGS len=0
        2022-05-28 12:35:04.365793032 Framer 0x400056c0e0: wrote SETTINGS flags=ACK len=0
        2022-05-28 12:35:04.367451862 Framer 0x400056c0e0: wrote SETTINGS len=12, settings: INITIAL_WINDOW_SIZE=0, MAX_FRAME_SIZE=16384
        2022-05-28 12:35:04.371392121 Framer 0x400056c0e0: wrote HEADERS flags=END_STREAM|END_HEADERS stream=1 len=16
        2022-05-28 12:35:06.624552592 Framer 0x400056c0e0: wrote RST_STREAM stream=1 len=4 ErrCode=CANCEL
FAIL
FAIL	golang.org/x/net/http2	79.864s

greplogs -l -e 'timeout waiting for Write in handler'
2022-05-27T14:59:03-5463443-03c2e56/netbsd-arm64-bsiegert
@bcmills
Copy link
Contributor Author

bcmills commented May 31, 2022

The hard-coded timeouts in testServerResponse look problematic to me, independent of platform:
https://cs.opensource.google/go/x/net/+/master:http2/server_test.go;l=2673;drc=183a9ca12b87817e0ced91cdd139606cbb193ef2
https://cs.opensource.google/go/x/net/+/master:http2/server_test.go;l=2682;drc=183a9ca12b87817e0ced91cdd139606cbb193ef2

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels May 31, 2022
@bcmills bcmills added this to the Backlog milestone May 31, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/409574 mentions this issue: http2: eliminate arbitrary timeouts in testServerResponse

@bcmills bcmills mentioned this issue May 31, 2022
Closed
@bcmills bcmills self-assigned this May 31, 2022
dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
@gopherbot
http2: eliminate arbitrary timeouts in testServerResponse
1855be7 
If the test deadlocks, we probably want a goroutine dump (which will
happen naturally if we allow the test to time out). Otherwise, these
arbitrary timeouts tend to only add noise on slower builders.

Fixes golang/go#53160 (maybe).

Change-Id: I2a95bf7fece27f949ab2cf9dea36fe440ac90d51
Reviewed-on: https://go-review.googlesource.com/c/net/+/409574
Reviewed-by: Damien Neil <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
@rsc rsc unassigned bcmills Jun 22, 2022
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang @gopherbot
http2: eliminate arbitrary timeouts in testServerResponse
d17b3c7 
If the test deadlocks, we probably want a goroutine dump (which will
happen naturally if we allow the test to time out). Otherwise, these
arbitrary timeouts tend to only add noise on slower builders.

Fixes golang/go#53160 (maybe).

Change-Id: I2a95bf7fece27f949ab2cf9dea36fe440ac90d51
Reviewed-on: https://go-review.googlesource.com/c/net/+/409574
Reviewed-by: Damien Neil <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot