x/vuln/cmd/govulncheck: stack overflow #51560
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
vulncheck or vulndb
Issues for the x/vuln or x/vulndb repo
Milestone
Comments
zpavlinovic
added
the
NeedsInvestigation
|
Does gopls/v0.6.0 perhaps use generics? |
|
Based on https://github.com/golang/tools/blob/gopls/v0.6.0/go.mod But it's possible some dependencies brought in generics code (note: I used |
|
Ok, will look into this next week. This is definitely unexpected, but likely has a simple fix. Let me know if this is should be a priority. |
|
Tried to reproduce this today. I got a different error. My best guess is this has something to do with the way generics and ssa interplay. |
zpavlinovic
changed the title
|
Note: the new version of govulncheck is now in x/vuln/cmd/govulncheck. The previous version is not supported anymore and has been deleted. |
|
I gotiped the latest version of Go and used the latest version of x/tools I can see the error, but it is yet a different one @taking, should we wait for upcoming ssa-generics changes before looking deeper? (Note, the above call stack is suggesting that T is a type parameter that appears as a Field of a named struct.) |
|
I'm @timothy-king on github. Apologies to @taking. I would wait. The panic is now blocked on #48525. |
Oops, my apologies too. |
|
#48525 should now be far enough along to retest this. |
|
Change https://go.dev/cl/399674 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Apr 12, 2022
Helper type logic did not handle properly pathological recursive types such as type B *B. This CL addresses that. For golang/go#51560 Change-Id: Ibb69ac68d77fc3956b98c701f17d28b9f30ac22c Reviewed-on: https://go-review.googlesource.com/c/tools/+/399674 Reviewed-by: Tim King <[email protected]> Run-TryBot: Zvonimir Pavlinovic <[email protected]> Auto-Submit: Zvonimir Pavlinovic <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
|
I believe this has been addressed. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version)?The problem exists with the
govulncheckbuilt with upgraded dependency forgolang.org/x/toolsWhat operating system and processor architecture are you using (
go env)?go envOutputWhat did you do?
I am not yet sure what exactly triggers this recursion in
go/callgraph/vta.My repro case is a pathological case - running
govulncheckwithallcan be unusual.Anyhow, I think it's not a bad idea to limit the recursion.
What did you expect to see?
Succeed, or fail with user-friendly message.
What did you see instead?
$ govulncheck -tests all runtime: goroutine stack exceeds 1000000000-byte limit runtime: sp=0xc115c00398 stack=[0xc115c00000, 0xc135c00000] fatal error: stack overflow runtime stack: runtime.throw({0x1457d88?, 0x1711060?}) /Users/hakim/sdk/gotip/src/runtime/panic.go:992 +0x71 runtime.newstack() /Users/hakim/sdk/gotip/src/runtime/stack.go:1101 +0x5cc runtime.morestack() /Users/hakim/sdk/gotip/src/runtime/asm_amd64.s:547 +0x8b goroutine 1 [running]: go/types.(*Named).Underlying(0xc03ca36460?) /Users/hakim/sdk/gotip/src/go/types/named.go:222 +0x3a fp=0xc115c003a8 sp=0xc115c003a0 pc=0x12e181a golang.org/x/tools/go/callgraph/vta.interfaceUnderPtr({0x1501cf8?, 0xc03ca36460?}) /Users/hakim/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/utils.go:88 +0x2b fp=0xc115c003d0 sp=0xc115c003a8 pc=0x137cf4b golang.org/x/tools/go/callgraph/vta.interfaceUnderPtr({0x1501cf8?, 0xc03ca36460?}) /Users/hakim/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/utils.go:97 +0x7e fp=0xc115c003f8 sp=0xc115c003d0 pc=0x137cf9e golang.org/x/tools/go/callgraph/vta.interfaceUnderPtr({0x1501cf8?, 0xc03ca36460?}) ... golang.org/x/tools/go/callgraph/vta.interfaceUnderPtr({0x1501cf8?, 0xc03ca36460?}) /Users/hakim/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/utils.go:97 +0x7e fp=0xc115c012f8 sp=0xc115c012d0 pc=0x137cf9e golang.org/x/tools/go/callgraph/vta.interfaceUnderPtr({0x1501cf8?, 0xc03ca36460?}) /Users/hakim/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/utils.go:97 +0x7e fp=0xc115c01320 sp=0xc115c012f8 pc=0x137cf9e ...additional frames elided... ...cc @zpavlinovic
The text was updated successfully, but these errors were encountered: