Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP client&server tests fail. DNS_ServerName and URL_Target strings conjoined into nonsense. #5

Closed
gopherbot opened this issue Nov 11, 2009 · 9 comments

Comments

@gopherbot
Copy link
Contributor

by twitwad:

What steps will reproduce the problem?
1. Install 6g on Intel Mac running 10.6.1
2. ./all.bash
3.

What is the expected output? What do you see instead?
Expected:

--- cd ../test
N known bugs; 0 unexpected bugs

What I see:

rm -f _test/http.a _gotest_.6
6g -o _gotest_.6 client.go fs.go request.go server.go status.go url.go   
client_test.go request_test.go url_test.go
rm -f _test/http.a
gopack grc _test/http.a _gotest_.6 
--- FAIL: http.TestClient
    Get http://www.google.com/robots.txt: dial tcp www.google.com:http: lookup
www.google.com.hsd1.pa.comcast.net. on 68.87.75.198:53: no answer from server

What is your $GOOS?  $GOARCH?
GOARCH-amd64, GOOS=darwin

Which revision are you sync'ed to?  (hg log -l 1)
changeset:   3952:64e703cb307d
tag:         tip
user:        Russ Cox <[email protected]>
date:        Tue Nov 10 14:09:01 2009 -0800
summary:     update video links


Please provide any additional information below.
My ISP is Comcast.
@gopherbot
Copy link
Contributor Author

Comment 1 by [email protected]:

This happens when OS X has the firewall enabled and won't let Go listen on a UDP port 
for the DNS response.  The workaround is either to disable the test (add http and net to 
NOTEST in $GOROOT/src/pkg/Makefile) or disable the firewall.

@gopherbot
Copy link
Contributor Author

Comment 2 by nathanollerenshaw:

I get this trying to build on a corporate network.

@gopherbot
Copy link
Contributor Author

Comment 3 by twitwad:

Great!  Worked like a charm and the rest of the tests passed.  Thanks!

@gopherbot
Copy link
Contributor Author

Comment 4 by ed.crump:

I'm getting something similar.  No firewall.
gopack grc _test/net.a _gotest_.6 
--- FAIL: net.TestDialError
    #2: nil error, want match for `dial tcp no-such-name.google.com.:80: lookup
no-such-name.google.com.( on .*)?: no (.*)`
    #3: nil error, want match for `dial tcp no-such-name.no-such-top-level-domain.:80:
lookup no-such-name.no-such-top-level-domain.( on .*)?: no (.*)`

@gopherbot
Copy link
Contributor Author

Comment 5 by cnhackTNT:

to ed.crump:
you should try another DNS, please edit your /etc/resolv.conf or edit your DNS option
via network manager something.

@gopherbot
Copy link
Contributor Author

Comment 6 by techknowlust:

I have the firewall disabled yet this problem persists. Is the only other workaround to 
disable testing net and http in the Makefile?

@rsc
Copy link
Contributor

rsc commented Nov 11, 2009

Comment 7:

TestDialError is now disabled by default.
hg pull
hg update release
should get you to a working state.

Status changed to Fixed.

@gopherbot
Copy link
Contributor Author

Comment 8 by aaron.blohowiak:

I just pulled and updated, and I am getting a similar error. 
gopack grc _test/http.a _gotest_.6 
--- FAIL: http.TestClient
    Get http://www.google.com/robots.txt: dial tcp www.google.com:http: open /etc/resolv.conf: no such 
file or directory
I do not have an /etc/resolv.conf -- python / bison / ed &c are installed using macports.
The installation *succeeds*, but the tests fail

@gopherbot
Copy link
Contributor Author

CL https://golang.org/cl/16470 mentions this issue.

gopherbot pushed a commit that referenced this issue Feb 26, 2016
This change adds support in testing/quick to generate maps and slices
in additional states:

  (1.) nil maps

  (2.) nil slices

  (3.) empty slice occupancy: `len(s) == 0 && s != nil`

  (4.) partial slice occupancy: `len(s) < cap(s) && s != nil`

  (5.) full slice occupancy: `len(s) == cap(s) && s != nil`

Prior to this, only #5 was ever generated, thereby not sufficiently
exercising all of the fuzzable code path outcomes.

This change depends on https://go-review.googlesource.com/#/c/17499/.

Change-Id: I9343c475cefbd72ffc5237281826465c25872206
Reviewed-on: https://go-review.googlesource.com/16470
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants