Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/go1.17: document encoding/binary changes for Go 1.17 #46009

Closed
gopherbot opened this issue May 6, 2021 · 2 comments
Closed

doc/go1.17: document encoding/binary changes for Go 1.17 #46009

gopherbot opened this issue May 6, 2021 · 2 comments
Labels
Documentation FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@gopherbot
Copy link
Contributor

As of filing this issue, the Go 1.17 draft release notes contained the following HTML:

encoding/binary

TODO: https://golang.org/cl/299531: limit bytes read by Uvarint to <= 10


This TODO needs to be resolved by July 1 so that we can have complete release notes for Beta 1.

A sequence of steps to resolve this issue may be:

  1. Come up with a draft release note entry in this issue, then move the issue to NeedsFix state.
  2. Send a CL with "doc/go1.17:" prefix and include "For doc: write Go 1.17 release notes #44513. Fixes doc/go1.17: document encoding/binary changes for Go 1.17 #46009." in the body.
@gopherbot gopherbot added Documentation help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels May 6, 2021
@gopherbot gopherbot added this to the Go1.17 milestone May 6, 2021
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/317929 mentions this issue: doc/go1.17: document encoding/binary.Uvarint max read of 10 bytes

@odeke-em
Copy link
Member

odeke-em commented May 7, 2021

Done, thanks for the tag Keith! I've mailed https://go-review.googlesource.com/c/go/+/317929

@golang golang locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Development

No branches or pull requests

2 participants