all: reopen tree for Go 1.17 development #44222

dmitshur · 2021-02-11T16:58:23Z

Current Tree Status: Open for Go 1.17 development (see golang-dev announcement)

As we're getting closer to the final Go 1.16 release, we will soon need to open the tree for Go 1.17 development.

As usual, the tree will initially be open to changes that must land early. Tentatively:

CL 275297 that bumps internal/goversion—this must be the very first CL to be submitted; CC @bcmills
dev.regabi branch will be merged to master as described here—tracking issue all: merge dev.regabi to master when tree reopens #44224; CC @cherrymui, @jeremyfaller
dev.typeparam branch will be merged to master assuming the proposal is accepted; CC @griesemer, @jeremyfaller
windows/arm64 @rsc
cmd/go lazy loading refactoring @bcmills
//go:build changes @rsc
(Add/reorder any other CLs or stacks or branches that must land early.)
Finally, open the tree for all general Go 1.17 changes.

We will send status updates to golang-dev@ as part of this work.

This is the tracking issue for completing this task.

CC @golang/release, @ianlancetaylor.

The text was updated successfully, but these errors were encountered:

dmitshur · 2021-02-16T17:16:15Z

It's planned by @golang/release for this issue to begin progressing after the Go 1.16 release is issued.

dmitshur · 2021-02-16T21:03:37Z

The "Current Tree Status" was just changed from "Frozen for Go 1.16 changes only" to "Accepting early Go 1.17 changes only (see list below)". I've sent a message to golang-dev.

I'll work with @bcmills on the first CL on the list.

bcmills · 2021-02-16T21:15:09Z

internal/goversion is in. Time to merge some branches (@cherrymui, @jeremyfaller)?

gopherbot · 2021-02-16T22:06:06Z

Change https://golang.org/cl/292709 mentions this issue: all: merge branch dev.regabi (d3cd4830ad) into master

This CL merges the dev.regabi branch to the master branch. In the dev.regabi branch we have refactored the compiler, and laid some preliminary work for enabling a register-based ABI (issue #40724), including improved late call/return lowering, improved ABI wrapper generation, reflect call prepared for the new ABI, and reserving special registers in the internal ABI. The actual register-based ABI has not been enabled for the moment. The ABI-related changes are behind GOEXPERIMENT=regabi and currently off by default. Updates #40724, #44222. Fixes #44224. Change-Id: Id5de9f734d14099267ab717167aaaeef31fdba70

dmitshur · 2021-02-17T14:26:08Z

Merging dev.regabi into master (issue #44224) was resolved (thank you @cherrymui). The next item currently in the list is:

dev.typeparam branch will be merged to master assuming the proposal is accepted; CC @griesemer, @jeremyfaller

When it's done (or if plans change), please update this issue and coordinate with the people working on the next item. Thank you!

griesemer · 2021-02-17T17:25:44Z

Quick update. Merging the dev.typeparams branch will require 1) to merge master into dev.typeparams (today), 2) isolating API changes that we may need for 1.18 but not for 1.17 (next couple of days), and then 3) merging dev.typeparams into master (hopefully by end of this week).

rsc · 2021-02-18T14:24:45Z

While we wait for dev.typeparams, it is OK for the cmd/go changes to proceed - I just checked and there are no changes in cmd/go on dev.typeparams.

rsc · 2021-02-18T14:28:36Z

It also looks OK for the windows/arm64 changes to proceed - there is no overlap except for one if statement in cmd/compile deciding about whether arm64 frame pointers are enabled, and dev.typeparams won't be changing that.

bcmills · 2021-02-19T01:23:07Z

The cmd/go changes that were ready to merge are in — we're all clear there from the perspective of opening the tree.

griesemer · 2021-02-19T01:43:20Z

Status update on dev.typeparams:

we've done a recent (this afternoon) merge from master, so dev.typeparams is tracking master closely
all outstanding CLs are in
the build looks green but for (now) linux-ppc64le-power9osu (API check killed)

Currently we are trying to get x/tools tests to pass: They rely on go/parser and go/types which have changed significantly. We have fixed several failures and should be down to one or two at the most by tonight. Once x/tools passes, we can merge once more with master (should be clean) and then dev.typeparams can be merged into master. Maybe tomorrow, and hopefully before Monday.

griesemer · 2021-02-19T05:19:31Z

Status update on dev.typeparams:

build looks green but for linux-ppc64le-power9osu (API check killed) and netbsd-argm64-bsiegert (intermittent failure)
x/tools seems to be ok but for x/tools/internal/lsp/source (but I may not have the correct setup, @findleyr will know more)

Once the lsp tests are deemed ok we should be ready to go. Next steps:

merge master -> dev.typeparams (expected to be trivial and conflict free)
merge dev.typeparams -> master

rsc · 2021-02-19T12:15:21Z

I merged the windows/arm64 changes last night and broke a few builders. I have CLs out for those.
(https://go-review.googlesource.com/c/go/+/294072/1 and below.)
We should probably wait to get those fixed before doing the dev.typeparams merge, but they should be fixed soon.

thanm · 2021-02-19T14:41:39Z

@dmitshur FYI, Russ has asked me to do an early submit https://go-review.googlesource.com/c/go/+/293309 with the fix for https://golang.org/issue/44344. Hope that is ok.

ianlancetaylor · 2021-02-19T14:50:30Z

I think the guidelines should be that pure bug fixes are OK at any time.

dmitshur · 2021-02-19T14:50:51Z

@thanm Yes, as Russ said that CL is a follow up to the dev.regabi merge and is okay. Thanks.

findleyr · 2021-02-19T15:16:45Z

Status update on dev.typeparams:

x/tools should now be green. I tested the merge in https://golang.org/cl/293770, and all Trybots succeeded (including x/tools). To be extra careful I'll also run x/tools tests on various other builders using gomote, though I'm not actually aware of changes in dev.typeparams that would cause failures on specific builders.

rsc · 2021-02-19T18:47:18Z

@findleyr and @griesemer are going to work on the dev.typeparams -> master merge in about an hour.
Consider the tree locked until they are done.

(The tooling requires that no commits appear on master between the preparatory master -> dev.typeparams merge and the final dev.typeparams -> master merge, so we can help them avoid doing multiple of the first merge by not submitting anything.)

Thanks!

griesemer · 2021-02-19T20:51:51Z

dev.typeparams has been merged into master.
(Perhaps give it 30min or so to settle on the build dashboard for a clear picture.)

rsc · 2021-02-19T20:52:10Z

dev.typeparams is merged.
I still have some pieces to pick up from windows/arm64, and I need to send in the //go:build CLs.
So we're not open for business yet.
But hopefully soon.
Watch this space.

rsc · 2021-02-20T01:06:07Z

If any +2'ers want to help move things along, once these reformatting CLs are in I think we can soft-open the tree.
https://go-review.googlesource.com/q/o:rsc+status:open+fmt

rsc · 2021-02-20T04:18:05Z

I've submitted what must be submitted before soft-reopening. I'm waiting for the dashboards to clear and will post when it is time. One more reformatting CL for anyone who wants it: https://go-review.googlesource.com/c/sys/+/294490.

rsc · 2021-02-20T05:11:33Z

OK, things look stable enough on the dashboard. Thanks for the reviews.

The tree is now open for bug fixes only.

This is a soft reopening for the weekend, before the full re-opening Monday.
An email to golang-dev@ will announce the full re-opening.
Again, bug fixes only for now.
No new features, new implementations, new API, etc. (Not yet.)

The compiler underwent major surgery during the freeze in preparation for generics,
and the runtime had minor surgery in preparation for the windows/arm64 port.
There is still a bug to find to revive windows/arm (32-bit), which I'll try to do in the next few days.
Everything else seems to be working decently on the dashboard.
But certainly there are bugs, and help finding and fixing them is always appreciated. :-)

Happy hacking!

dmitshur · 2021-02-22T22:49:44Z

The "Current Tree Status" was updated from "Open for bug fixes only" to "Open for Go 1.17 development". I've sent an announcement to golang-dev.

Closing, as this issue is resolved. Thanks everyone!

dmitshur added NeedsFix The path to resolution is known, but the work has not been done. early-in-cycle A change that should be done early in the 3 month dev cycle. labels Feb 11, 2021

dmitshur added this to the Go1.17 milestone Feb 11, 2021

gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 11, 2021

dmitshur added the umbrella label Feb 11, 2021

dmitshur self-assigned this Feb 16, 2021

dmitshur mentioned this issue Feb 16, 2021

all: merge dev.regabi to master when tree reopens #44224

Closed

rsc changed the title ~~x/build: reopen tree for Go 1.17 development~~ all: reopen tree for Go 1.17 development Feb 18, 2021

dmitshur closed this as completed Feb 22, 2021

jeremyfaller mentioned this issue Feb 23, 2021

Go compiler and runtime meeting notes #43930

Open

golang deleted a comment from Budda0ne Mar 7, 2021

mewmew mentioned this issue Mar 15, 2021

[proposal] graph: evaluate what the Graph API may look like in Go 2 gonum/gonum#617

Open

golang locked and limited conversation to collaborators Mar 7, 2022

gopherbot added the FrozenDueToAge label Mar 7, 2022

rsc unassigned dmitshur Jun 23, 2022

heschi moved this to Done in Go Release Sep 27, 2022

heschi added this to Go Release Sep 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: reopen tree for Go 1.17 development #44222

all: reopen tree for Go 1.17 development #44222

dmitshur commented Feb 11, 2021 •

edited

Loading

dmitshur commented Feb 16, 2021

dmitshur commented Feb 16, 2021

bcmills commented Feb 16, 2021

gopherbot commented Feb 16, 2021

dmitshur commented Feb 17, 2021

griesemer commented Feb 17, 2021

rsc commented Feb 18, 2021

rsc commented Feb 18, 2021

bcmills commented Feb 19, 2021

griesemer commented Feb 19, 2021

griesemer commented Feb 19, 2021

rsc commented Feb 19, 2021 •

edited

Loading

thanm commented Feb 19, 2021

ianlancetaylor commented Feb 19, 2021

dmitshur commented Feb 19, 2021

findleyr commented Feb 19, 2021

rsc commented Feb 19, 2021 •

edited

Loading

griesemer commented Feb 19, 2021

rsc commented Feb 19, 2021

rsc commented Feb 20, 2021

rsc commented Feb 20, 2021

rsc commented Feb 20, 2021

dmitshur commented Feb 22, 2021

all: reopen tree for Go 1.17 development #44222

all: reopen tree for Go 1.17 development #44222

Comments

dmitshur commented Feb 11, 2021 • edited Loading

Current Tree Status: Open for Go 1.17 development (see golang-dev announcement)

dmitshur commented Feb 16, 2021

dmitshur commented Feb 16, 2021

bcmills commented Feb 16, 2021

gopherbot commented Feb 16, 2021

dmitshur commented Feb 17, 2021

griesemer commented Feb 17, 2021

rsc commented Feb 18, 2021

rsc commented Feb 18, 2021

bcmills commented Feb 19, 2021

griesemer commented Feb 19, 2021

griesemer commented Feb 19, 2021

rsc commented Feb 19, 2021 • edited Loading

thanm commented Feb 19, 2021

ianlancetaylor commented Feb 19, 2021

dmitshur commented Feb 19, 2021

findleyr commented Feb 19, 2021

rsc commented Feb 19, 2021 • edited Loading

griesemer commented Feb 19, 2021

rsc commented Feb 19, 2021

rsc commented Feb 20, 2021

rsc commented Feb 20, 2021

rsc commented Feb 20, 2021

dmitshur commented Feb 22, 2021

dmitshur commented Feb 11, 2021 •

edited

Loading

rsc commented Feb 19, 2021 •

edited

Loading

rsc commented Feb 19, 2021 •

edited

Loading