-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/dashboard: add misc-compile-darwinarm64 trybot #42341
Comments
Change https://golang.org/cl/267105 mentions this issue: |
I think it should start to work after CL https://go-review.googlesource.com/c/go/+/265121 , a.k.a. b85c2dd. |
Great, I've made that commit required in CL 267105. |
Create the builder as a post-submit builder with a non-zero KnownIssue value first. Once we know it works well, we'll have the confidence to be able to safely promote it to a normal TryBot, without the risk of causing disruption for contributors. It's different from misc-compile-darwin since it needs to run on recent Go 1.16 commits only. For golang/go#42341. Change-Id: I67170988d7323cb73439755a3961532c668040e7 Reviewed-on: https://go-review.googlesource.com/c/build/+/267105 Trust: Dmitri Shuralyov <[email protected]> Reviewed-by: Cherry Zhang <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
Change https://golang.org/cl/267123 mentions this issue: |
There's a bit more to do before this TryBot becomes alive; reopening. I think what's left is to resolve #42377, then it should work. |
Change https://golang.org/cl/267677 mentions this issue: |
Change https://golang.org/cl/268057 mentions this issue: |
It's working as expected so far. Here's a TryBot run from a recent CL: Build Log
In contrast with CL 268057 which intentionally adds invalid code for macOS arm64 only: Build Log
|
The vast majority of the time, when Go 1.X (or Go 1.X.Y) is the latest supported Go release, non-release branches are used for developing the next Go 1.(X+1) version and not the same Go 1.X version. Adjust the imperfect heuristic used to determine the Go version from the branch name by taking this into account. Make the output from the TestFindTryWork test easier to read, as it's expensive to add test coverage for this change elsewhere. For golang/go#42341. Fixes golang/go#42377. Updates golang/go#42376. Change-Id: I70b21662f2a4c853d14a0928f8bd7361fc6aafd6 Reviewed-on: https://go-review.googlesource.com/c/build/+/267677 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> Trust: Dmitri Shuralyov <[email protected]>
This is live as of CL 267123 and CL 267677, so closing. If there are issues, please let me know. Thank you for your work to make this possible @cherrymui! |
@cherrymui has notified me that the darwin/arm64 port now supports internal linking, meaning we can cross-compile for darwin/arm64 without needing a C compiler.
Let's add a misc-compile trybot for it, since it's possible now. As all misc-compiler trybots, it will run buildall.bash to cross-compile & vet std+cmd packages, but not run any tests. It should first be added as a normal post-submit builder with a non-zero KnownIssue (similar to CL 257617) before being graduated to a proper trybot.
This helps with #39782 (but doesn't replace it, since a misc-compile builder doesn't run any tests).
@cherrymui Starting with what Go commit do you expect it to work?
CC @golang/release.
The text was updated successfully, but these errors were encountered: