Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: the first write error on a connection will cause all subsequent write requests to fail blindly [1.15 backport] #42113

Closed
gopherbot opened this issue Oct 21, 2020 · 5 comments
Closed

x/net/http2: the first write error on a connection will cause all subsequent write requests to fail blindly [1.15 backport] #42113

gopherbot opened this issue Oct 21, 2020 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.15.4

Comments

@gopherbot
Copy link
Contributor

@bradfitz requested issue #39337 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport. I think this is pretty bad. (It bit us and there's no great workaround, short of disabling HTTP/2)
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 21, 2020
@gopherbot gopherbot mentioned this issue Oct 21, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.4 milestone Oct 21, 2020
@cagedmantis
Copy link
Contributor

Approved as this is a serious issue without a workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Oct 23, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 23, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/266158 mentions this issue: [release-branch.go1.15-bundle] http2: close Transport connection on write errors

gopherbot pushed a commit to golang/net that referenced this issue Oct 29, 2020
@fraenkel @dmitshur
[release-branch.go1.15-bundle] http2: close Transport connection on w…
0704177 
…rite errors

When a new connection is created, and a write error occurs during the
initial exchange, the connection must be closed. There is no guarantee
that the caller will close the connection.

When a connection with an existing write error is used or being used, it
will stay in use until its read loop completes. Requests will continue
to use this connection and fail when writing its header. These
connections should be closed to force the cleanup in its readLoop.

Updates golang/go#39337.
For golang/go#42113.

Change-Id: I45e1293309e40629531f4cbb69387864f4f71bc2
Reviewed-on: https://go-review.googlesource.com/c/net/+/240337
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Trust: Brad Fitzpatrick <[email protected]>
Trust: Damien Neil <[email protected]>
(cherry picked from commit f585440)
Reviewed-on: https://go-review.googlesource.com/c/net/+/266158
Trust: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Emmanuel Odeke <[email protected]>
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/266375 mentions this issue: [release-branch.go1.15] net/http: update bundled x/net/http2

gopherbot pushed a commit that referenced this issue Oct 30, 2020
@dmitshur
[release-branch.go1.15] net/http: update bundled x/net/http2
ef3039e 
Bring in the change in CL 266158 with:

	go mod edit -replace=golang.org/x/net=golang.org/x/[email protected]
	GOFLAGS='-mod=mod' go generate -run=bundle std
	go mod edit -dropreplace=golang.org/x/net
	go get -d golang.org/x/[email protected]
	go mod tidy
	go mod vendor

Updates #39337.
Fixes #42113.

Change-Id: I3ebef4b90c11ad271b7a3031aafd80c423c2c241
Reviewed-on: https://go-review.googlesource.com/c/go/+/266375
Trust: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Emmanuel Odeke <[email protected]>
@dmitshur
Copy link
Contributor

Closed by merging ef3039e to release-branch.go1.15.

@gopherbot

This comment has been minimized.

Sign in to view
@dmitshur dmitshur self-assigned this Nov 2, 2020
@bcbee bcbee mentioned this issue Nov 19, 2020
Closed
@golang golang locked and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.15.4
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot