net: remove dependency on fmt, unicode via golang.org/x/net/dns/dnsmessage #40070
Labels
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
release-blocker
Milestone
Comments
rsc
added
NeedsFix
|
Change https://golang.org/cl/241078 mentions this issue: |
|
Change https://golang.org/cl/241085 mentions this issue: |
gopherbot
pushed a commit
to golang/net
that referenced
this issue
Jul 7, 2020
This package cannot use fmt, because standard package net imports it. (Most of the package is already clean, including Type.String.) For golang/go#40070. Change-Id: I9be92e98d9f5dcfb26852d38004e05f07df5e17a Reviewed-on: https://go-review.googlesource.com/c/net/+/241085 Run-TryBot: Russ Cox <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
gopherbot
pushed a commit
that referenced
this issue
Jul 7, 2020
TestDependencies defines the dependency policy (what can depend on what) for the standard library. The standard library has outgrown the idea of writing the policy as a plain map literal. Also, the checker was ignoring vendored packages, which makes it miss real problems. This commit adds a little language for describing partial orders and rewrites the policy in that language. It also changes the checker to look inside vendored packages and adds those to the policy as well. This turned up one important problem: net is depending on fmt, unicode via golang.org/x/net/dns/dnsmessage, filed as #40070. This is a test-only change, so it should be appropriate even for the release freeze, especially since it identified a real bug. Change-Id: I9b79f30761f167b8587204c959baa973583e39f2 Reviewed-on: https://go-review.googlesource.com/c/go/+/241078 Run-TryBot: Russ Cox <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
|
Is there anything else to do here? As far as I can tell this issue can be closed. |
|
Change https://golang.org/cl/285213 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Jan 25, 2021
For #40070 For #41191 For #43469 For #43632 Change-Id: I6dc6b6ea0f35876a4c252e4e287a0280aca9d502 Reviewed-on: https://go-review.googlesource.com/c/go/+/285213 Trust: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
net should not depend on fmt and unicode.
golang.org/x/net/dns/dnsmessage contains one line using fmt:
But dnsmessage is vendored into the standard library and imported by net,
and this use is making net depend on fmt, and in turn on unicode.
This one line should be changed, to remove the use of fmt.
go/build.TestDependencies claims to check that net does not
depend on unicode, which should have detected this, but that
test does not look inside vendored packages.
I have a fix that I will send out for that problem as well.
The text was updated successfully, but these errors were encountered: