Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestBuildIDContainsArchModeEnv/386 fails on linux/386 in Go 1.14 and 1.13, not 1.15 [1.14 backport] #39824

Closed
gopherbot opened this issue Jun 24, 2020 · 3 comments
Closed

cmd/go: TestBuildIDContainsArchModeEnv/386 fails on linux/386 in Go 1.14 and 1.13, not 1.15 [1.14 backport] #39824

gopherbot opened this issue Jun 24, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14.6

Comments

@gopherbot
Copy link
Contributor

@dmitshur requested issue #39544 to be considered for backport to the next 1.14 minor release.

@gopherbot Please backport to the last 2 releases. This is a test fix. It makes a cmd/go test less strict and enables it to pass in all environments, which matches the behavior of the same test in the latest version, which has been confirmed to be most optimal.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 24, 2020
@gopherbot gopherbot mentioned this issue Jun 24, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.5 milestone Jun 24, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/239738 mentions this issue: [release-branch.go1.14] cmd/go: convert TestBuildIDContainsArchModeEnv to the script framework

@cagedmantis
Copy link
Contributor

This is a serious issue with no workaround which impacts the release process. Approved.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Jun 29, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 29, 2020
@gopherbot
Copy link
Contributor Author

Closed by merging efed90a to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Jun 29, 2020
@matloob @cagedmantis
[release-branch.go1.14] cmd/go: convert TestBuildIDContainsArchModeEn…
efed90a 
…v to the script framework

Part of converting all tests to script framework to improve
test parallelism.

Fixes #39824
Updates #36320
Updates #17751

Change-Id: I69c69809fb1698c8198ef3ea00103a9acb7b6ce7
Reviewed-on: https://go-review.googlesource.com/c/go/+/214387
Run-TryBot: Michael Matloob <[email protected]>
Reviewed-by: Jay Conrod <[email protected]>
(cherry picked from CL 214387)
Reviewed-on: https://go-review.googlesource.com/c/go/+/239738
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Michael Matloob <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 29, 2020
@andybons andybons modified the milestones: Go1.14.5, Go1.14.6 Jul 14, 2020
@golang golang locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14.6
Development

No branches or pull requests
4 participants
@cagedmantis @andybons @dmitshur @gopherbot