Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: BuildNameToCertificate deprecated in go 1.14 not mentioned in the release notes [1.14 backport] #38030

Closed
gopherbot opened this issue Mar 23, 2020 · 5 comments
Closed

doc: BuildNameToCertificate deprecated in go 1.14 not mentioned in the release notes [1.14 backport] #38030

gopherbot opened this issue Mar 23, 2020 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation Issues describing a change to documentation. FrozenDueToAge
Milestone
Go1.14.6

Comments

@gopherbot
Copy link
Contributor

@FiloSottile requested issue #37626 to be considered for backport to the next 1.14 minor release.

@gopherbot please open a backport issue for Go 1.14, this is a documentation change that needs to go live on golang.org.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 23, 2020
@gopherbot gopherbot mentioned this issue Mar 23, 2020
Closed
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Mar 23, 2020
@gopherbot gopherbot added this to the Go1.14.2 milestone Mar 23, 2020
@dmitshur
Copy link
Contributor

Approving, as this is a documentation fix.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 23, 2020
@gopherbot gopherbot mentioned this issue Mar 30, 2020
Closed
@gopherbot

This comment has been minimized.

Sign in to view
@andybons andybons modified the milestones: Go1.14.2, Go1.14.3 Apr 8, 2020
@andybons andybons modified the milestones: Go1.14.3, Go1.14.4 May 14, 2020
@dmitshur dmitshur modified the milestones: Go1.14.4, Go1.14.5 Jun 1, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/240011 mentions this issue: [release-branch.go1.14] doc/go1.14: crypto/tls.Config.NameToCertificate is deprecated

@gopherbot
Copy link
Contributor Author

Closed by merging 67d894e to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Jun 26, 2020
@ianlancetaylor
[release-branch.go1.14] doc/go1.14: crypto/tls.Config.NameToCertifica…
67d894e 
…te is deprecated

Also crypto/tls.Config.BuildNameToCertificate.

Note that this field and method were deprecated in the Go 1.14 release,
so this change is to the 1.14 release notes.

For #37626
Fixes #38030

Change-Id: If8549bc746f42a93f1903439e1b464b3e81e2c19
Reviewed-on: https://go-review.googlesource.com/c/go/+/240005
Reviewed-by: Filippo Valsorda <[email protected]>
(cherry picked from commit 186e61f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/240011
@andybons andybons modified the milestones: Go1.14.5, Go1.14.6 Jul 14, 2020
@golang golang locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Milestone
Go1.14.6
Development

No branches or pull requests
4 participants
@andybons @dmitshur @gopherbot and others