Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: -d=checkptr should not reject unaligned pointers to non-pointer data [1.14 backport] #37905

Closed
gopherbot opened this issue Mar 17, 2020 · 3 comments
Closed

cmd/compile: -d=checkptr should not reject unaligned pointers to non-pointer data [1.14 backport] #37905

gopherbot opened this issue Mar 17, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.14.1

Comments

@gopherbot
Copy link
Contributor

@cagedmantis requested issue #37298 to be considered for backport to the next 1.14 minor release.

@gopherbot please open a backport issue to 1.14.1
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 17, 2020
@gopherbot gopherbot mentioned this issue Mar 17, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.1 milestone Mar 17, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/223749 mentions this issue: runtime: don't report a pointer alignment error for pointer-free base type

@cagedmantis
Copy link
Contributor

This cherry-pick is approved, as it is a serious issue without a workaround.

@cagedmantis cagedmantis added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 17, 2020
gopherbot pushed a commit that referenced this issue Mar 18, 2020
@randall77 @cagedmantis
[release-branch.go1.14] runtime: don't report a pointer alignment err…
229247d 
…or for pointer-free base type

Fixes #37905

Change-Id: I8ba9c8b106e16cea7dd25473c7390b0f2ba9a1a5
Reviewed-on: https://go-review.googlesource.com/c/go/+/223781
Run-TryBot: Keith Randall <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/223749
@gopherbot
Copy link
Contributor Author

Closed by merging 229247d to release-branch.go1.14.

@akrylysov akrylysov mentioned this issue Apr 2, 2020
Closed
@golang golang locked and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.14.1
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot