Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: remove darwin/arm (32-bit) #37611

Closed
andybons opened this issue Mar 2, 2020 · 10 comments
Closed

all: remove darwin/arm (32-bit) #37611

andybons opened this issue Mar 2, 2020 · 10 comments
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.15

Comments

@andybons
Copy link
Member

andybons commented Mar 2, 2020

Per #34751, we are removing darwin/arm (but keeping darwin/arm64).
@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Mar 2, 2020
@andybons andybons added this to the Go1.15 milestone Mar 2, 2020
@andybons andybons self-assigned this Mar 2, 2020
@andybons andybons added the mobile Android, iOS, and x/mobile label Mar 2, 2020
@andybons andybons mentioned this issue Mar 2, 2020
Closed
@andybons andybons assigned aclements and unassigned andybons Mar 9, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/222720 mentions this issue: dashboard: remove darwin-arm-mg912baios and darwin-arm64-mn4m2zdaios

gopherbot pushed a commit to golang/build that referenced this issue Mar 10, 2020
@andybons
dashboard: remove darwin-arm-mg912baios and darwin-arm64-mn4m2zdaios
4424759 
These have been consistently failing for weeks and attempts to
contact the owner have been unsuccessful.

Updates golang/go#37611
Fixes golang/go#31497

Change-Id: I43c8b9de18c758d256290ee42eb3755dd9eacf3f
Reviewed-on: https://go-review.googlesource.com/c/build/+/222720
Run-TryBot: Andrew Bonventre <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/227080 mentions this issue: cmd/dist: remove darwin/arm as a valid port

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/227198 mentions this issue: all: remove scattered remnants of darwin/arm

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/227197 mentions this issue: all: remove darwin/arm build-tags and files

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/226985 mentions this issue: cmd/dist: remove darwin/386, darwin/arm as valid ports

@gopherbot

This comment has been minimized.

Sign in to view
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/227181 mentions this issue: dashboard: update misc-compile-darwin description

gopherbot pushed a commit that referenced this issue Apr 4, 2020
@bradfitz
cmd/dist: remove darwin/386, darwin/arm as valid ports
9f40f9f 
This only removes the ability to build it, and removes it as a
src/buildall.bash target (which uses go tool dist list).

Now:

$ go tool dist list | grep ^darwin
darwin/amd64
darwin/arm64

After this, remaining is removing leftover port--specific code in the
tree.

Updates #37610
Updates #37611

Change-Id: I00f03b2355c2e152f75e57abd3063be243529d2d
Reviewed-on: https://go-review.googlesource.com/c/go/+/226985
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Filippo Valsorda <[email protected]>
@sthagen sthagen mentioned this issue Apr 4, 2020
Merged
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/227341 mentions this issue: cmd/link: remove darwin/arm test

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/227343 mentions this issue: doc: remove darwin/386, darwin/arm from ports list

gopherbot pushed a commit that referenced this issue Apr 6, 2020
@cherrymui
cmd/link: remove darwin/arm test
7dc1c62 
The darwin/arm port is removed in Go 1.15. Setting GOOS=darwin
GOARCH=arm will fail, therefore "go test cmd/link" on macOS will
fail (in non -short mode). Remove this test point.

Updates #37611.

Change-Id: Ia9531c4b4a6692a0c49153517af9fdddd1f3e0bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/227341
Reviewed-by: Ian Lance Taylor <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Apr 6, 2020
@dmitshur
dashboard: disable darwin/386 builder on master
0e423fd 
The 32-bit pairs darwin/386 and darwin/arm are removed in Go 1.15,
and the master branch is where Go 1.15 is being developed.
The builder has started to fail after CL 226985 (as intended),
so remove it. Keep it running on Go 1.14 and 1.13 release branches.

Also update the misc-compile-darwin builder description.

For golang/go#37610.
For golang/go#37611.

Change-Id: Ia70386c5ae2821b4397048dcb0862a066463d6de
Reviewed-on: https://go-review.googlesource.com/c/build/+/227181
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Andrew Bonventre <[email protected]>
gopherbot pushed a commit that referenced this issue Apr 8, 2020
@aclements
doc: remove darwin/386, darwin/arm from ports list
79b6900 
Updates #37611.

Change-Id: I7ae5a61d2e2189fd48ac3548e370e0de1dd79832
Reviewed-on: https://go-review.googlesource.com/c/go/+/227343
Run-TryBot: Austin Clements <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Cherry Zhang <[email protected]>
gopherbot pushed a commit that referenced this issue Apr 8, 2020
@aclements
all: remove darwin/arm build-tags and files
da8591b 
This removes all files that are only used on darwin/arm and cleans up
build tags in files that are still used on other platforms.

Updates #37611.

Change-Id: Ic9490cf0edfc157c6276a7ca950c1768b34a998f
Reviewed-on: https://go-review.googlesource.com/c/go/+/227197
Run-TryBot: Austin Clements <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Cherry Zhang <[email protected]>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/229323 mentions this issue: [dev.link] cmd/link, cmd/oldlink: remove remaining darwin/386 and darwin/arm code

gopherbot pushed a commit that referenced this issue Apr 22, 2020
@cherrymui
[dev.link] cmd/link, cmd/oldlink: remove more darwin/386 and darwin/a…
d8ab105 
…rm code

Updates #37610, #37611.

Change-Id: I0a497af03e24ddea40ed3e342f3a9362bf21ac0c
Reviewed-on: https://go-review.googlesource.com/c/go/+/229323
Run-TryBot: Cherry Zhang <[email protected]>
Reviewed-by: Austin Clements <[email protected]>
xujianhai666 pushed a commit to xujianhai666/go-1 that referenced this issue May 21, 2020
@cherrymui @xujianhai666
[dev.link] cmd/link, cmd/oldlink: remove more darwin/386 and darwin/a…
abac923 
…rm code

Updates golang#37610, golang#37611.

Change-Id: I0a497af03e24ddea40ed3e342f3a9362bf21ac0c
Reviewed-on: https://go-review.googlesource.com/c/go/+/229323
Run-TryBot: Cherry Zhang <[email protected]>
Reviewed-by: Austin Clements <[email protected]>
@golang golang locked and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
3 participants
@andybons @aclements @gopherbot