Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: "unknown directive" in TestScript/mod_concurrent #35425

Closed
bcmills opened this issue Nov 7, 2019 · 4 comments
Closed

cmd/go: "unknown directive" in TestScript/mod_concurrent #35425

bcmills opened this issue Nov 7, 2019 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 7, 2019

linux-amd64-nocgo (https://build.golang.org/log/4668306396e340463394550d95aee1d8b4867350):

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_concurrent (0.05s)
        script_test.go:192: 
            # Concurrent builds should succeed, even if they need to download modules. (0.043s)
            > go build ./x &
            > go build ./y
            [stderr]
            go: downloading rsc.io/sampler v1.0.0
            > wait
            [background] go build ./x: exit status 1
            [stderr]
            go: errors parsing go.mod:
            $WORK/gopath/src/go.mod:7: unknown directive: v1.0.0
            $WORK/gopath/src/go.mod:8: unknown directive: )
            FAIL: testdata/script/mod_concurrent.txt:6: unexpected command failure
            
FAIL
FAIL	cmd/go	77.618s

I've only seen one of these failures, but this failure mode suggests a possible bug in CL 205637.

CC @jayconrod
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 7, 2019
@bcmills bcmills added this to the Go1.14 milestone Nov 7, 2019
@bcmills bcmills self-assigned this Nov 7, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Nov 8, 2019

openbsd-amd64-64: https://storage.googleapis.com/go-build-log/9034f739/openbsd-amd64-64_f534ce96.log

@bcmills
Copy link
Contributor Author

bcmills commented Nov 8, 2019

freebsd-386-12_0: https://build.golang.org/log/32b22820193997af284f1912917faa5912d45844

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/206142 mentions this issue: cmd/go/internal/modload: use lockedfile.Read for the initial read of the go.mod file

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/206143 mentions this issue: cmd/go/internal/lockedfile: add a unit-test for Transform

gopherbot pushed a commit that referenced this issue Nov 8, 2019
cmd/go/internal/lockedfile: add a unit-test for Transform
a84ac18 
Updates #35425

Change-Id: I9ca2251246ee2fa9bb7a335d5eff94d3c9f1f004
Reviewed-on: https://go-review.googlesource.com/c/go/+/206143
Reviewed-by: Brad Fitzpatrick <[email protected]>
@golang golang locked and limited conversation to collaborators Nov 7, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
2 participants
@bcmills @gopherbot