-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gccgo: ICE in mangled_name for packagepath with .0 #33871
Labels
Milestone
Comments
Change https://golang.org/cl/200837 mentions this issue: |
Change https://golang.org/cl/200838 mentions this issue: |
kraj
pushed a commit
to kraj/gcc
that referenced
this issue
Oct 12, 2019
We need to mangle dots to avoid problems with -fgo-pkgpath=a.0. That will confuse the name mangling, which assumes that names entering the mangling cannot contain arbitrary dot characters. We don't need to mangle other characters; go_encode_id will handle them. Fixes golang/go#33871 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/200838 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@276913 138bc75d-0d04-0410-961f-82ee72b054a4
gopherbot
pushed a commit
that referenced
this issue
Oct 15, 2019
Updates #33871 Change-Id: I73b1513a89ad89126159ce03ee72b922cd01916c Reviewed-on: https://go-review.googlesource.com/c/go/+/200837 Run-TryBot: Ian Lance Taylor <[email protected]> Run-TryBot: Bryan C. Mills <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Than McIntosh <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
emsr
pushed a commit
to emsr/gcc
that referenced
this issue
Nov 2, 2019
We need to mangle dots to avoid problems with -fgo-pkgpath=a.0. That will confuse the name mangling, which assumes that names entering the mangling cannot contain arbitrary dot characters. We don't need to mangle other characters; go_encode_id will handle them. Fixes golang/go#33871 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/200838 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@276913 138bc75d-0d04-0410-961f-82ee72b054a4
asiekierka
pushed a commit
to WonderfulToolchain/gcc-ia16
that referenced
this issue
May 16, 2022
We need to mangle dots to avoid problems with -fgo-pkgpath=a.0. That will confuse the name mangling, which assumes that names entering the mangling cannot contain arbitrary dot characters. We don't need to mangle other characters; go_encode_id will handle them. Fixes golang/go#33871 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/200838 From-SVN: r276913
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version
)?gccgo tip, linux/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
This actually cropped up while building a package in module mode, via
due to a module path of the form "protobuf/internal/testprotos/legacy/proto2.v0.0.0-20160225-2fc053c5". There is a simpler way to reproduce, however, via the following.
In $GOPATH/src, create a subdir "a.0.0", then in that dir place this file:
Then do:
What did you expect to see?
Clean build.
What did you see instead?
This error:
The text was updated successfully, but these errors were encountered: