Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: Transport is leaking streams on broken Body [1.11 backport] #28673

Closed
gopherbot opened this issue Nov 8, 2018 · 6 comments
Closed

x/net/http2: Transport is leaking streams on broken Body [1.11 backport] #28673

gopherbot opened this issue Nov 8, 2018 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.11.4

Comments

@gopherbot
Copy link
Contributor

@bradfitz requested issue #27208 to be considered for backport to the next 1.11 minor release.

@gopherbot, please backport to Go 1.11.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 8, 2018
@gopherbot gopherbot mentioned this issue Nov 8, 2018
Closed
@gopherbot gopherbot added this to the Go1.11.3 milestone Nov 8, 2018
@bradfitz bradfitz added the CherryPickApproved Used during the release process for point releases label Nov 8, 2018
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 8, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Nov 8, 2018

Note that this is a tricky one: it requires an x/net cherry-pick followed by a manual bundle into std's net/http h2_bundle.go file.

/cc @dmitshur

@mrahbar mrahbar mentioned this issue Nov 20, 2018
Closed
@dmitshur dmitshur modified the milestones: Go1.11.3, Go1.11.4 Dec 13, 2018
@dmitshur dmitshur self-assigned this Dec 14, 2018
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/154237 mentions this issue: [release-branch.go1.11] http2: don't leak streams on broken body

@gopherbot
Copy link
Contributor Author

Closed by merging a4630153038d3cb8c57f83d95200aea356145cf5 to release-branch.go1.11.

gopherbot pushed a commit to golang/net that referenced this issue Dec 14, 2018
@dmitshur
[release-branch.go1.11] http2: don't leak streams on broken body
a463015 
Updates golang/go#28673

Change-Id: I5d9a643f33d27d33b24f670c98f5a51aa6000967
GitHub-Last-Rev: 3ac4a57
GitHub-Pull-Request: #18
Reviewed-on: https://go-review.googlesource.com/c/132715
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
(cherry picked from commit 1c5f79c)
Reviewed-on: https://go-review.googlesource.com/c/154237
@dmitshur
Copy link
Contributor

Re-opening for bundling into standard library's net/http h2_bundle.go file.

@dmitshur dmitshur reopened this Dec 14, 2018
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/154298 mentions this issue: [release-branch.go1.11] net/http: update bundled x/net/http2

@bradfitz
Copy link
Contributor

bradfitz commented Dec 14, 2018 •
edited by dmitshur
Loading

Why is gopherbot closing this?

Edit by @dmitshur: It was because of #29270, which has been resolved now.

@bradfitz bradfitz reopened this Dec 14, 2018
@bradfitz bradfitz reopened this Dec 14, 2018
@bradfitz bradfitz mentioned this issue Dec 14, 2018
Closed
gopherbot pushed a commit that referenced this issue Dec 14, 2018
@dmitshur @FiloSottile
[release-branch.go1.11] net/http: update bundled x/net/http2
66f0997 
This updates x/net/http2 to x/net on the latest commit of x/net on
release-branch.go1.11 branch, golang/net@a4630153038d3cb8c57f, for:

	[release-branch.go1.11] http2: don't leak streams on broken body
	https://golang.org/cl/154237

Fixes #28673

Change-Id: I8f40c69502fa95d1d9dff1ab68444640444442aa
Reviewed-on: https://go-review.googlesource.com/c/154298
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@386898917 386898917 mentioned this issue Dec 29, 2018
Open
@golang golang locked and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.11.4
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot